bugwdiff - Bugs: bug #25883, Better handling of non-seekable...

 
 

bug #25883: Better handling of non-seekable input

Submitted by:  Martin von Gagern <gagern>
Submitted on:  Mon 16 Mar 2009 11:12:37 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Martin von Gagern <gagern>
Originator Name:  Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 15 Dec 2009 05:12:12 PM UTC, comment #1: 

Fix comitted, will be included in next release.

Martin von Gagern <gagern>
Project AdministratorIn charge of this item.
Mon 16 Mar 2009 11:12:37 AM UTC, original submission:  

I tend to use shell process substitutions a lot with diff. However, when I try to do the same with wdiff, I loose output without any indication that anything might have gone wrong. To test this, try the following:
wdiff <(echo here foo there) <(echo here bar there)

The primary cause of this is that this kind of input is not seekable. wdiff already contains some code to copy input to a temporary file, but it uses that method only for stdin.

The attached patch checks whether or not a stream is seekable, and copies it to a temporary buffer if not. With this patch in place, the above command produces the expected output. As an added benefit, in cases where stdin is seekable, unnecessary buffering is avoided, though this case is probably rare.

Martin von Gagern <gagern>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #17705:  NonSeekableInput.patch added by gagern (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gagern (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-12-15 gagern StatusNone => Fixed
        Assigned toNone => gagern
        Open/ClosedOpen => Closed
    2009-03-16 gagern Attached File- => Added NonSeekableInput.patch, #17705

    Back to the top


    Powered by Savane 3.5