buglibiconv - Bugs: bug #63758, new srclib and srcm4 files missing...

 
 

bug #63758: new srclib and srcm4 files missing from .gitignore

Submitter:  Jay Freeman (saurik) <saurik>
Submitted:  Sat 04 Feb 2023 09:37:21 PM UTC
   
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  Not a Bug
Privacy:  Public Assigned to:  haible
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 05 Feb 2023 08:00:14 PM UTC, comment #1: 

Thanks for the suggestion.

I have a requirement that I don't want to have garbage files, that I happen to create in the source tree during development, to appear in tarballs.

For GNU libiconv, I create tarballs either through 'make dist' - which just includes all *.m4 files from srcm4 - or through a 'tarme' script - that, even worse, includes all files from srcm4 and srclib except for backup files. So, either way, there is a need to verify the list of files. I use the .gitignore file for this purpose.

In projects where the creation of a tarball uses an explicit list of files, such as an EXTRA_DIST list maintained by hand or generated by Automake, it is possible to do as you suggest, namely to list the entire srclib/ and srcm4/ directories in .gitignore and never be bothered about them again.

So, here, I currently wish to stay with the "use 'git status -u' every now and then" approach.

Bruno Haible <haible>
Group administrator
Sat 04 Feb 2023 09:37:21 PM UTC, original submission:  

$ git status --untracked-files=all
HEAD detached at origin/master
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        srclib/assert.in.h
        srclib/intprops-internal.h
        srclib/stdckdint.in.h
        srcm4/assert_h.m4
        srcm4/c-bool.m4

nothing added to commit but untracked files present (use "git add" to track)

FWIW, I've noticed .gitignore is currently carefully organized to list every single file in every single folder as part of various stages of the build, but I'll note that this heavily encourages skew over time as you have to remember to update that file every time any change is made (and maybe even to automake).

However, the simple reality is that everything under srcm4 should be ignored and all files under srclib except Makefile.am should be ignored, and so you can replace over half the contents of the file with a much simpler set of three rules (though this would break the careful staged organization you currently have).

!/srclib/Makefile.am
/srclib/*
/srcm4/*

Jay Freeman (saurik) <saurik>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Posted a comment)
  • -email is unavailable- added by saurik (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-05 haible StatusNone Not a Bug
        Assigned toNone haible
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code