buglibiconv - Bugs: bug #62491, libcharset_set_relocation_prefix...

 
 

bug #62491: libcharset_set_relocation_prefix not exported

Submitter:  None
Submitted:  Fri 20 May 2022 10:59:05 AM UTC
   
 
Category:  Build Severity:  3 - Normal
Item Group:  None Status:  Not a Bug
Privacy:  Public Assigned to:  haible
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 21 May 2022 05:28:44 PM UTC, comment #1: 

I can see that the same patch is also found at
https://github.com/conan-io/conan-center-index/blob/master/recipes/libiconv/all/patches/0001-libcharset-fix-linkage.patch
and
https://github.com/microsoft/vcpkg/blob/master/ports/libiconv/0003-Add-export.patch

But it is wrong, because once the header is installed in a public location, LIBCHARSET_DLL_EXPORTED needs to be defined as a C macro (otherwise the package that uses this include file gets a syntax error).

And it is not needed, because at build time the package uses include/libcharset.h.build.in (see configure.ac line 62), and this file does contain a LIBCHARSET_DLL_EXPORTED definition and use.

Bruno Haible <haible>
Group administrator
Fri 20 May 2022 10:59:05 AM UTC, original submission:  

The function libcharset_set_relocation_prefix is not exported.

--- a/libcharset/include/libcharset.h.in
+++ b/libcharset/include/libcharset.h.in
@@ -33,7 +33,7 @@
    by the corresponding pathname with the current prefix instead.  Both
    prefixes should be directory names without trailing slash (i.e. use ""
    instead of "/").  */
-extern void libcharset_set_relocation_prefix (const char *orig_prefix,
+extern LIBCHARSET_DLL_EXPORTED void libcharset_set_relocation_prefix (const char *orig_prefix,
                                               const char *curr_prefix);


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-05-21 haible StatusNone Not a Bug
        Assigned toNone haible
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code