GNU Astronomy Utilities - Bugs: bug #58640, Error in calculation of SIP to TPV...
You are not allowed to post comments on this tracker with your current authentication level.
bug #58640: Error in calculation of SIP to TPV coversions
Submitter: | Sachin Kumar Singh <sks_15> | ||
Submitted: | Mon 22 Jun 2020 01:03:55 PM UTC | ||
Category: | Fits | Severity: | 3 - Normal |
Item Group: | Output not reasonable | Status: | Fixed |
Privacy: | Public | Assigned to: | sks_15 |
Open/Closed: | Closed |
Jump to the original submission
Wed 24 Jun 2020 12:17:17 AM UTC, comment #15: |
Sachin Kumar Singh <sks_15> |
Wed 24 Jun 2020 12:13:37 AM UTC, comment #14: Thanks for the check Raul ;-)! I am closing the task now.
|
Mohammad Akhlaghi <makhlaghi> |
Tue 23 Jun 2020 11:09:46 PM UTC, comment #13: Thanks a log guys, now it seems to be good. As you can see the agreement between them are almost perfect! :-)
|
Raul Infante-Sainz <infantesainz> |
Tue 23 Jun 2020 04:51:32 PM UTC, comment #12: Thanks Sachin, I just merged the branch in to 'master' in Commit ebeef2b94389d. You can now delete it the branch on your fork (its best for branches to be deleted as soon as they are merged).
|
Mohammad Akhlaghi <makhlaghi> |
Tue 23 Jun 2020 04:30:27 PM UTC, comment #11: Also, major changes were the initialisation using loops. If anything else comes up, I'll do the changes.
|
Sachin Kumar Singh <sks_15> |
Tue 23 Jun 2020 04:25:24 PM UTC, comment #10: I've pushed it on task-sip-tpv branch on gitlab. We can fix more changes over it.
|
Sachin Kumar Singh <sks_15> |
Tue 23 Jun 2020 03:51:52 PM UTC, comment #9: Thanks for the fix Sachin, so it isn't yet implemented. I just opened the task until we can confirm that it is fixed ;-).
|
Mohammad Akhlaghi <makhlaghi> |
Tue 23 Jun 2020 03:37:05 PM UTC, comment #8: It's a very small change I've pushed it on the bug-fix branch on my gitlab branch. |
Sachin Kumar Singh <sks_15> |
Tue 23 Jun 2020 03:28:08 PM UTC, comment #7: Sachin, do you mean that it is correct in Commit 7dca196b6f7f?
|
Mohammad Akhlaghi <makhlaghi> |
Tue 23 Jun 2020 03:20:51 PM UTC, comment #6: The error was due to reading of SIP.REV instead of SIP.FWD keyword which was fine before but was changed by mistake and it read reverse coefficients(which are approximately equal to forward coefficients but opposite in sign) and hence was causing negative values and somewhat different results. |
Sachin Kumar Singh <sks_15> |
Tue 23 Jun 2020 02:54:20 PM UTC, comment #5: There was a silly error I made a few commits ago. I've fixed it now and it should produce almost similar to sip_tpv module. I think we can close this task now. |
Sachin Kumar Singh <sks_15> |
Tue 23 Jun 2020 01:57:42 PM UTC, comment #4: In a private discussion, Sachin just pointed out that the PV2* keywords have the wrong opposite sign (as if multiplied by -1). He is working on finding the cause and fixing it.
|
Mohammad Akhlaghi <makhlaghi> |
Tue 23 Jun 2020 01:55:08 AM UTC, comment #3: Thanks a lot for the check Raul! I just rebased all the work on this test branch (which was originally started for bug #58623) as one commit into Gnuastro (Commit 7dca196b6f7f5884).
|
Mohammad Akhlaghi <makhlaghi> |
Mon 22 Jun 2020 10:58:36 PM UTC, comment #2: Thanks Mohammad.
|
Raul Infante-Sainz <infantesainz> |
Mon 22 Jun 2020 05:10:42 PM UTC, comment #1: Raul, can you try this tarball (for Comment 8 or task 15676): http://akhlaghi.org/src/gnuastro-0.12.13-81d57.tar.lz
|
Mohammad Akhlaghi <makhlaghi> |
Mon 22 Jun 2020 01:03:55 PM UTC, original submission:
Some discussions are done in task #15676 related to some false values resulting when SIP->TPV conversions are done. This is a continuation of the the thread in task $15676. |
Sachin Kumar Singh <sks_15> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 17 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-06-24 | sks_15 | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2020-06-24 | sks_15 | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2020-06-24 | makhlaghi | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2020-06-23 | sks_15 | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2020-06-23 | sks_15 | Open/Closed | Open | Closed | |
2020-06-23 | makhlaghi | Open/Closed | Closed | Open | |
2020-06-23 | sks_15 | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2020-06-23 | makhlaghi | Status | Fixed | In Progress | |
Open/Closed | Closed | Open | |||
2020-06-23 | makhlaghi | Status | In Progress | Fixed | |
Open/Closed | Open | Closed | |||
2020-06-22 | makhlaghi | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-d3ae.
Corresponding source code
That's great! Thanks Raul for testing:-):-)
PVi_j are coefficients of some x^m*y^n in a tpv equation(also given in the comments). Also, PVi_3 and PVi_11(in current implementation order only up to 16) are radial terms and hence not used. So it's just that some coefficients might have a 0 value in the equation for given parameters and hence are missing,