bugGNU Astronomy Utilities - Bugs: bug #58623, Problem during building of...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58623: Problem during building of wcsdistortion library in macOS

Submitted by:  Sachin Kumar Singh <sks_15>
Submitted on:  Fri 19 Jun 2020 12:03:26 PM UTC  
 
Category:  Installation Severity:  3 - Normal
Item Group:  Crash Status:  Fixed
Privacy:  Public Assigned to:  Sachin Kumar Singh <sks_15>
Open/Closed:  Closed

( Jump to the original submission)

Tue 23 Jun 2020 01:52:09 AM UTC, comment #8: 

This work (together with bug #58640) have been pushed into the master branch with Commit 7dca196b6f7.

Since this particular bug is now fixed, I am closing this bug. If another user later finds a crash, we'll open a new bug for that different condition ;-).

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Mon 22 Jun 2020 12:37:23 PM UTC, comment #7: 

Great!! But I think we should keep this open until a release(and even sometimes after a release) so that any other user can post their related problems without opening a lot of bugs.

Sachin Kumar Singh <sks_15>
Project MemberIn charge of this item.
Mon 22 Jun 2020 11:32:54 AM UTC, comment #6: 

Now it was installed without any problem! So this bug can be closed. I posted in the other thread a small test I did with one image. Thanks a lot! :-)

Raul Infante-Sainz <infantesainz>
Project Member
Sun 21 Jun 2020 09:39:11 PM UTC, comment #5: 

Raul, can you please try this tarball: http://akhlaghi.org/src/gnuastro-0.12.12-4a2e.tar.lz

If this tarball builds without a problem on your system, can you please also check it with the sip_tpv Python program on your macOS with an image to see if the results are consistent?

Sachin was able to remove the usage of 'dpkeyd', so it should cause a problem on your version of WCSLIB (this problem wasn't macOS-related).

Furthermore, in Commit 4a2ef8878ec0, I added a configure-time check to avoid all distortion-related operations when the WCSLIB is too old (older than Raul's version, this won't be a problem on Raul's system).

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sat 20 Jun 2020 09:47:15 PM UTC, comment #4: 

The configure step didn't crash, but the make crashed. Attached I compressed the standard output during the configure and the make (-j1) to let you investigate the problem. I think you are getting closer ;-)

(file #49334)

Raul Infante-Sainz <infantesainz>
Project Member
Sat 20 Jun 2020 05:11:27 PM UTC, comment #3: 

Raul, can you try building this tarball: http://akhlaghi.org/src/gnuastro-0.12.10-1a029.tar.lz

It should ideally not have any warnings and should also compile. But its not yet merged into the master branch in case we have missed some other problems.

Sachin, I added a configure-check to avoid the 'mjdref' element of the 'wcsprm' when the host doesn't have it. You can see my commit on the 'bug-fixes' branch of my development fork.

I also went through 'wcsdistortion.c' and done some style fixes, for example the initializations are now in one line (more readable), and all the places where '++i' is the same as 'i++', I changed to '++i' (this is a convention in Gnuastro which I guess I haven't written yet, it is more clear and efficient). Generally, have a look at the changes and keep them in mind for future work ;-).

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sat 20 Jun 2020 02:45:49 PM UTC, comment #2: 

The problem with initialisation was solved with the use of nested loops to provide compatability with clang. It is pushed here.

Sachin Kumar Singh <sks_15>
Project MemberIn charge of this item.
Fri 19 Jun 2020 11:49:53 PM UTC, comment #1: 

Thanks a lot Sachin. Attached you can have a look at the `wcs.h' file you asked for ;-)

(file #49324)

Raul Infante-Sainz <infantesainz>
Project Member
Fri 19 Jun 2020 12:03:26 PM UTC, original submission:  

There are some errors showing up during the building process of gnuastro due to the wcsdistortion library. It's discussed more in task #15676.

This bug was found bu Raul Infante-Sainz.

Sachin Kumar Singh <sks_15>
Project MemberIn charge of this item.

 

Attached Files
file #49334:  configure-make.tar.gz added by infantesainz (181KiB - application/x-gzip)
file #49324:  wcs.h added by infantesainz (71KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by infantesainz (Updated the item)
  • -email is unavailable- added by sks_15 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-06-23 makhlaghi StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2020-06-21 makhlaghi StatusPostponed => In Progress
    2020-06-20 infantesainz Attached File- => Added configure-make.tar.gz, #49334
    2020-06-19 infantesainz Attached File- => Added wcs.h, #49324

    Back to the top


    Powered by Savane 3.5