bugCompact Disc Input and Control Library - Bugs: bug #57736, ja cd-paranoia.1 Makefile path...

 
 

bug #57736: ja cd-paranoia.1 Makefile path incorrect

Submitter:  None
Submitted:  Tue 04 Feb 2020 12:59:34 AM UTC
   
 
Category:  compilation Severity:  5 - Average
Item Group:  cd-paranoia Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 09 Feb 2020 04:03:37 AM UTC, comment #6: 

Try this again.

Rocky Bernstein,
I closed my github account when Microsoft bought it.

Thomas Kupper,
Thank you for taking the time to make the patch.
You make take full credit for it. I didn't test your
patch yet, but I'm sure it will be fine.

Thank you both.

bo darville <darville>
Sun 09 Feb 2020 03:34:33 AM UTC, comment #5: 


comment #2:

> Hey,
>
> I had a quick look into it and I'm afraid you missed a Makefile.am :)
>
> In doc/ja/Makefile.am there you find
>
>     mansubdir=/jp/man1
>
> I created a branch which fix the correct mansubdir on github. The file is installed in the 'ja' folder on my macOS but I can't test it since I don't have a clue about Japanses.
>
>     https://github.com/boretom/libcdio-paranoia/tree/fix/ja-cd-paranoia.1-Makefile-path-incorrect
>
> ... and the patch for  the typo is included here since it's just a typo.
>
> If the submitter could test if that solves this issue and report back, that'd be helpful. And if it does fix it I would create a pull request on Github for it, if the submitter of this bug doesn't mind.
>
> (file #48374)

bo darville <darville>
Sat 08 Feb 2020 10:56:47 AM UTC, comment #4: 

I didn't realize the submission was anonymous (although it says exactly that next to the post slap-to-the-forhead). Your suggestion about a timeout period sound good. I set myself a reminder a week from now.

Although I'm not really good at creating an app I enjoy debugging others code quite a lot :)

Thomas Kupper <patient0>
Sat 08 Feb 2020 10:42:38 AM UTC, comment #3: 

patient0 reports:

> I had a quick look into it and I'm afraid you missed a Makefile.am :)


I make a lot of mistakes. That's one reason I work on debuggers.

> I created a branch which fix the correct mansubdir on github. The file is installed in the 'ja' folder on my macOS but I can't test it since I don't have a clue about Japanese.


Thanks!

> If the submitter could test if that solves this issue and report back, that'd be helpful. And if it does fix it I would create a pull request on Github for it, if the submitter of this bug doesn't mind.


Ok. But the submitter posted this annonymously which means she won't be notified about updates automatically. In my experience, annonymous bug reporters make a comment and then disappear.


So a suggestion is to give a timeout period for testing and response and if nothing happens move forward.

Personally, I'd rather have new bugs (trying to fix the old ones) rather than keep the same old boring bugs.

Again, thanks for undertaking this.

Rocky Bernstein <rocky>
Group administrator
Sat 08 Feb 2020 10:26:03 AM UTC, comment #2: 

Hey,

I had a quick look into it and I'm afraid you missed a Makefile.am :)

In doc/ja/Makefile.am there you find

    mansubdir=/jp/man1

I created a branch which fix the correct mansubdir on github. The file is installed in the 'ja' folder on my macOS but I can't test it since I don't have a clue about Japanses.

    https://github.com/boretom/libcdio-paranoia/tree/fix/ja-cd-paranoia.1-Makefile-path-incorrect

... and the patch for  the typo is included here since it's just a typo.

If the submitter could test if that solves this issue and report back, that'd be helpful. And if it does fix it I would create a pull request on Github for it, if the submitter of this bug doesn't mind.

(file #48374)

Thomas Kupper <patient0>
Tue 04 Feb 2020 01:11:00 AM UTC, comment #1: 

Thanks for the bug report, detailed analysis and suggestions.

libcdio-paranoia work is now being done in github, i.e. https://github.com/rocky/libcdio-paranoia would you open an issue there https://github.com/rocky/libcdio-paranoia/issues to log this.

Even better would be to make a pull request the suggested changes.

Thanks!

Rocky Bernstein <rocky>
Group administrator
Tue 04 Feb 2020 12:59:34 AM UTC, original submission:  

Issue: doc/ja/cd-paranoia.1 is not rendering correctly.

libcdio-paranoia 10.2+2.0.1
OS: Linux
man-db: 2.9.0

man(1) encoding conversion is dependent upon the file's path.

The build system is installing it in the wrong subdirectory:
doc/ja/Makefile.am:18
mansubdir=/jp/man1

s/jp/ja/

So:
mansubdir=/ja/man1

Then man(1) will render it correctly.

The source tree correctly uses 'ja':
doc/ja/cd-paranoia.1

That location is part of the FHS[1] and man-db[2] specifications.

Other optional mitigation steps:
If this line is added to the top of the man page:

  '\" -*- coding: EUC-JP -*-

it will render properly regardless of path.

Or if the man page is converted to utf-8 it will
also render properly regardless of path:

cat cd-paranoia.1 | iconv -f eucjp -t utf8 > utf-cd-paranoia.1

It is recommended by man-db that man pages be utf-8 encoded.

[1] 4.11.6. /usr/share/man : Manual pages:
    https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.txt

[2] "NLS manual pages"
http://git.savannah.nongnu.org/cgit/man-db.git/tree/manual/files.me#n212

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #48374:  fix-jp-mansubdir-typo.patch added by patient0 (449B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by darville (Posted a comment)
  • -email is unavailable- added by patient0 (Updated the item)
  • -email is unavailable- added by rocky (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-05-22 rocky StatusNone Fixed
        Open/ClosedOpen Closed
    2020-02-08 patient0 Attached File- Added fix-jp-mansubdir-typo.patch, #48374

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code