bugCompact Disc Input and Control Library - Bugs: bug #57216, 2.1.0: test suite is core dumping

 
 

bug #57216: 2.1.0: test suite is core dumping

Submitted by:  Tomasz Kłoczko <kloczek>
Submitted on:  Wed 13 Nov 2019 12:42:05 AM UTC  
 
Category:  None Severity:  5 - Average
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  None
Open/Closed:  Open

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 13 Nov 2019 02:44:24 PM UTC, comment #5: 

Because abort() is correct for an assert() statement.

Rocky Bernstein <rocky>
Project Administrator
Wed 13 Nov 2019 02:32:09 PM UTC, comment #4: 

Yes abort() is causomg core dumping.
Why not use exit() with non-zero value ?

Tomasz Kłoczko <kloczek>
Wed 13 Nov 2019 01:48:58 PM UTC, comment #3: 

The function cdio_assert calls the standard C library routine abort();  see http://git.savannah.gnu.org/cgit/libcdio.git/tree/lib/driver/logging.c#n74 I believe that is what it should do. If you have arranged for abort() to cause a core dump, then in my view, that's the right thing to do here.

Rocky Bernstein <rocky>
Project Administrator
Wed 13 Nov 2019 12:23:55 PM UTC, comment #2: 

So why that test cannot just exit wit non-zero exit code?
Dumpig core is very strange way to confirm that everything is OK.
In my build env I'm monitoring and couting such things like core dumps.

Tomasz Kłoczko <kloczek>
Wed 13 Nov 2019 01:14:35 AM UTC, comment #1: 

I'm not sure this is a problem. The testassert program is supposed to fail and abort. The surrounding autoconf test suite then expects a failure.

Rocky Bernstein <rocky>
Project Administrator
Wed 13 Nov 2019 12:42:05 AM UTC, original submission:  

[tkloczko@barrel SPECS]$ coredumpctl gdb /home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/test/.libs/lt-testassert
           PID: 1560058 (lt-testassert)
           UID: 1000 (tkloczko)
           GID: 1000 (tkloczko)
        Signal: 6 (ABRT)
     Timestamp: Wed 2019-11-13 00:39:00 GMT (23s ago)
  Command Line: /home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/test/.libs/lt-testassert
    Executable: /home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/test/.libs/lt-testassert
 Control Group: /user.slice/user-1000.slice/session-19.scope
          Unit: session-19.scope
         Slice: user-1000.slice
       Session: 19
     Owner UID: 1000 (tkloczko)
       Boot ID: e845e24d8267413294b5cd37fcd69ecd
    Machine ID: 2a07404e0c70431ba36bfb0ac8e023c2
      Hostname: barrel
       Storage: /var/lib/systemd/coredump/core.lt-testassert.1000.e845e24d8267413294b5cd37fcd69ecd.1560058.1573605540000000000000.lz4
       Message: Process 1560058 (lt-testassert) of user 1000 dumped core.

               

                Stack trace of thread 1560058:
                #0  0x00007f53a96075b5 raise (libc.so.6)
                #1  0x00007f53a95f0899 abort (libc.so.6)
                #2  0x00007f53a95afaa0 n/a (/home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/lib/driver/.libs/libcdio.so.19.0.0)

GNU gdb (GDB) Fedora 9.0.50.20191018-1.fc32
Copyright (C) 2019 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-redhat-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/test/.libs/lt-testassert...
[New LWP 1560058]
Core was generated by `/home/tkloczko/rpmbuild/BUILD/libcdio-2.1.0/test/.libs/lt-testassert'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f53a96075b5 in raise () from /lib64/libc.so.6
 glibc-2.30.9000-17.fc32.x86_64
(gdb) bt full
Missing separate debuginfos, use: dnf debuginfo-install#0  0x00007f53a96075b5 in raise () from /lib64/libc.so.6
No symbol table info available.
#1  0x00007f53a95f0899 in abort () from /lib64/libc.so.6
No symbol table info available.
#2  0x00007f53a95afaa0 in cdio_default_log_handler (level=<optimized out>, message=<optimized out>) at logging.c:74
        _PRETTY_FUNCTION_ = "cdio_default_log_handler"
#3  0x00007f53a95aea5c in cdio_logv (level=CDIO_LOG_ASSERT, format=<optimized out>, args=args@entry=0x7fff6142e180) at logging.c:123
        buf = "file testassert.c: line 30 (main): should not be reached", '\000' <repeats 967 times>
        _PRETTY_FUNCTION_ = "cdio_logv"
        in_recursion = 1
#4  0x00007f53a95af9b6 in cdio_log (level=<optimized out>, format=<optimized out>) at logging.c:133
        args = {{gp_offset = 40, fp_offset = 48, overflow_arg_area = 0x7fff6142e260, reg_save_area = 0x7fff6142e1a0}}
#5  0x000056244b6cc0ac in main (argc=<optimized out>, argv=<optimized out>) at testassert.c:30
        _PRETTY_FUNCTION_ = "main"
(gdb)

Tomasz Kłoczko <kloczek>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by kloczek (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-11-13 rocky StatusNone => Wont Fix

    Back to the top


    Powered by Savane 3.5