bugGNU Robots - Bugs: bug #57037, build fails with -pedantic-errors...

 
 

bug #57037: build fails with -pedantic-errors and -Werror compiler options

Submitter:  Mike Miller <mtmiller>
Submitted:  Thu 10 Oct 2019 06:51:52 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Privacy:  Public Assigned to:  rozzin
Open/Closed:  Closed Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 28 Oct 2019 02:57:41 AM UTC, comment #1: 

Agreed. Applied in git.

Joshua Judson Rosen <rozzin>
Group administrator
Thu 10 Oct 2019 06:51:52 PM UTC, original submission:  

I understand the desire to keep the strictest possible compiler flags enabled while doing development and reviewing code contributions. However, the options -Werror and -pedantic-errors are generally less useful when they are included in the default build options and distributed to users. The build fails for me because of deprecation warnings, turned into errors by these options, in the version of the GTK+2.0 library on my system.

The attached patch removes these options unconditionally. I think it would be appropriate to add a configure option like "--enable-strictest-flags" if you want to make it easier to build with these flags, and I'd be happy to help implement and test such an option if you want.

Mike Miller <mtmiller>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47646:  gnurobots-werror.patch added by mtmiller (926B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rozzin (Updated the item)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-10-28 rozzin StatusNone Fixed
        Assigned toNone rozzin
        Open/ClosedOpen Closed
    2019-10-10 mtmiller Attached File- Added gnurobots-werror.patch, #47646

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code