bugCompact Disc Input and Control Library - Bugs: bug #56240, cdda-player works fine under NetBSD

 
 

bug #56240: cdda-player works fine under NetBSD

Submitter:  None
Submitted:  Tue 30 Apr 2019 07:15:26 AM UTC
   
 
Category:  configuration Severity:  5 - Average
Item Group:  cdda-player Status:  Fixed
Privacy:  Public Assigned to:  vext01
Originator Email:  -email is unavailable- Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 04 May 2019 10:52:15 AM UTC, comment #3: 

I've reverted the commit in question.

Thanks for the report.

Edd Barrett <vext01>
Group Member
Tue 30 Apr 2019 12:33:05 PM UTC, comment #2: 

Ok - I don't remember why I did that. Let's assum it was due to some other problem that has since been fixed.

For example we were picking up pkg-config wrong in 1f94664f766ef66b992e1c53a5e817a37988d894

Edd - I'd be grateful if you reverted my mistake and tried this out on netbsd/openbsd.

(After that I'll be removing what looks like OS/2 configuration stuff that I noticed because this is adjacent.)

Rocky Bernstein <rocky>
Group administrator
Tue 30 Apr 2019 12:22:57 PM UTC, comment #1: 

Hi,

This was recently discussed on the mailing list.

Rocky disabled cdda-player in this commit:
http://git.savannah.gnu.org/cgit/libcdio.git/commit/?id=123db461efef93b05401b7918afe4d05f78d8cb2

I'm happy to revert it if Rocky is happy with that.

Edd Barrett <vext01>
Group Member
Tue 30 Apr 2019 07:15:26 AM UTC, original submission:  

I don't know why building of cdda-player has been disabled for NetBSD (and OpenBSD), but the player works fine on NetBSD.

Use the following patch to re-enable cdda-player for these platforms.

--- configure.ac.orig 2019-04-30 07:14:15.000000000 +0000
+++ configure.ac
@@ -508,7 +508,6 @@ int has_timeout=sizeof(test.timeout);],
                   [Define 1 if you have NetBSD CD-ROM support])
  # LIBS="$LIBS -lcam"
   cd_drivers="${cd_drivers}, NetBSD "
- enable_cdda_player="no"
  ;;
      os2*)
        AC_DEFINE([HAVE_OS2_CDROM], [1],

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by vext01 (Posted a comment)
  • -email is unavailable- added by rocky (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-04 vext01 StatusNone Fixed
        Open/ClosedOpen Closed
    2019-04-30 rocky Assigned toNone vext01

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code