bugGNU source-highlight - Bugs: bug #55967, Don't use black in esc.style

 
 

bug #55967: Don't use black in esc.style

Submitted by:  Owen Taylor <otaylor>
Submitted on:  Wed 20 Mar 2019 04:49:58 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 01 Jun 2019 07:45:02 PM UTC, comment #2: 

This seems like a reasonable idea, so I implemented it.

Tom Tromey <tromey>
Project Administrator
Wed 20 Mar 2019 04:56:37 PM UTC, comment #1: 
Owen Taylor <otaylor>
Wed 20 Mar 2019 04:49:58 PM UTC, original submission:  

Right now, esc.style has:

  function black b;

which doesn't work at all in a terminal with a black or dark background. Changing this to:

  function b;

greatly improves how things look - there definitely could be further tweaks to make things work better on different backgrounds, but this would be a good start, and should barely change the appearance on a light background.

Owen Taylor <otaylor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by tromey (Posted a comment)
  • -email is unavailable- added by otaylor (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-06-01 tromey Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.5