Add a New Comment (Rich Markup)
Comment Type & Canned Response: None No canned response available
Pushed as well, thanks.
Incremental fix attached, please review/comment.
Unfortunately after more testing I found that my fix is incomplete. If an ed-style patch modifies more than one file, then we still leak a temporary file for all but the last file. I'll look for a better fix.
This looks acceptable. Applied, thanks.
I have attached a candidate fix, please review/comment.
If an ed-style patch fails to apply, an unreadable temporary file named pe<something> is leaked. This happens in the test suite itself, so running "make check" triggers the bug:
$ ls /tmp/pe* ls: cannot access '/tmp/pe*': No such file or directory $ make check (...) PASS: ed-style (...) $ ls /tmp/pe* /tmp/peu3RLvw $
This temporary file leak was introduced by commit 123eaff0d5d1 ("Fix arbitrary command execution in ed-style patches (CVE-2018-1000156)").
(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)
Attach Files: Comment:
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Only logged-in users can vote.
Please enter the title of George Orwell's famous dystopian book (it's a date):
Follow 4 latest changes.
Copyright © 2022 Free Software Foundation, Inc. Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved. The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team. Source Code
Powered by Savane 3.9