bugGnash - The GNU Flash player - Bugs: bug #17789, -b switch not working

 
 

bug #17789: -b switch not working

Submitter:  None
Submitted:  Mon 18 Sep 2006 12:44:53 PM UTC
   
 
Category:  gui Severity:  3 - Normal
Release:  None Status:  Fixed
Privacy:  Public Assigned to:  bjacques
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Mon 07 Jan 2008 04:23:29 PM UTC, comment #8: 

Dropped (at least for this release).

Benjamin Wolsey <bwy>
Group Member
Tue 18 Sep 2007 03:52:41 PM UTC, comment #7: 

Agree, I'd drop the -b option.

AFAIK it only matters when using the SDL gui and -b 16 has a poor quality. It's better to render in truecolor (24/32) mode and let the gfx driver (or whatever) do the interpolation, if necessary at all.

Udo Giacomozzi <udog>
Group Member
Tue 18 Sep 2007 01:17:27 AM UTC, comment #6: 

I am not sure what does Udo think of this.

I agree with Martin, drop -b option.

Even with cvs head, 16 bit depth is only supported by SDL and not 100% correct IIRC.

See related bug #20868.


Zou Lunkai <zoulunkai>
Mon 17 Sep 2007 03:28:31 PM UTC, comment #5: 

What does Udo think of this ? And Zou ?

Sandro Santilli <strk>
Group Member
Sun 16 Sep 2007 05:36:16 PM UTC, comment #4: 

Usually the bit depths available are fairly limited (usually it's one) so it's probably not worth making this flag work. So I'm leaning towards removing it entirely.

Bastiaan Jacques <bjacques>
Group Member
Fri 06 Jul 2007 04:09:04 PM UTC, comment #3: 

Every GUI except SDL totally ignores -b. You can give any value and it is ignored.

For SDL:
  with AGG it must be 16, 24 or 32 - with other values it says "Assertion 0 failed"

  with cairo, any value other than 32 the movie runs but has  a totally blank screen.

  with opengl any value other than 32 provokes the failure message
lt-gnash: /home/martin/lulu/gnash/gui/sdl_ogl_glue.cpp:96: virtual bool gnash::SdlOglGlue::prepDrawingArea(int, int, uint32_t): Assertion `_bpp == 32' failed.
Aborted

I suggest we drop the -b flag and eliminate the bit_depth/bpp/_depth parameters and members entirely (*) and let the individual glue files decide on an appropriate bit depth for the render buffer.
For most renderers it is fixed at 32, while AGG would do best to set it to the same as the screen or FB bit depth so that the buffer-to-screen copy is as fast as possible.

(*) Carefully - there are other members of other classes called "_depth" which refer to the z-buffer depth of a movie character on the stage.

Martin Guy <martinwguy>
Thu 09 Nov 2006 11:45:51 AM UTC, comment #2: 

The assertion is now removed, but seems that -b option has no effect (-b0 , -b1 , -b16 , ecc. show the same graphics).

Anonymous
Fri 03 Nov 2006 09:18:44 AM UTC, comment #1: 

Seems that now whatever -b x I pass to gnash (current 0.7.2), it works without any error or warning. Is this correct?

Anonymous
Mon 18 Sep 2006 12:44:53 PM UTC, original submission:  

When I use gnash -b x
with b different from 16 or 32 I get this:

gnash: gnash.cpp:308: gnash.cpp:308: Assertion `!bit_depth || bit_depth == 16 || bit_depth == 32' failed.
Aborted

It should exit more cleanly, something like:
Error: bit depth of output window is invalid. Supported values are 16 or 32, default is 16.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bwy (Posted a comment)
  • -email is unavailable- added by udog (Posted a comment)
  • -email is unavailable- added by zoulunkai (Posted a comment)
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by strk
  • -email is unavailable- added by strk
  • -email is unavailable- added by bjacques (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-01-07 bwy StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2007-09-17 strk Carbon-Copy- Added udog
        Carbon-Copy- Added zoulunkai
    2007-09-16 bjacques StatusNone Confirmed
    2006-11-09 strk CategoryNone gui
        Severity2 - Minor 3 - Normal
        SummaryAssertion `!bit_depth || bit_depth == 16 || bit_depth == 32' failed -b switch not working
    2006-09-23 bjacques Severity3 - Normal 2 - Minor
        Assigned toNone bjacques

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code