patchCompact Disc Input and Control Library - Patches: patch #9167, minor fixes for cross-compile...

 
 

patch #9167: minor fixes for cross-compile friendliness

Submitter:  Ozkan Sezer <sezero>
Submitted:  Sat 19 Nov 2016 08:16:44 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  rocky Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 20 Nov 2016 07:29:24 PM UTC, comment #2: 

Thanks. I think this can be closed now.

Ozkan Sezer <sezero>
Sun 20 Nov 2016 06:31:06 PM UTC, comment #1: 

Thanks for the patches.

With commit bab7685 all of these should be in now.

Please double check. If that does it close this, or let me know.

Rocky Bernstein <rocky>
Group administrator
Sat 19 Nov 2016 08:16:44 PM UTC, original submission:  

[Posting the patches here, because the mail didn't arrive with
the patches attached to the mailing list at
http://lists.gnu.org/archive/html/libcdio-devel/2016-11/msg00000.html]

Attached are four small patches to libcdio, mostly for cross-
compile friendliness.

0001: stdlib.h and string.h are needed for malloc, strlen and
  strncpy in lib/driver/cdio_private.h

0002: do not call 'nm' directly, use the NM variable instead
  in lib/driver/Makefile.am and lib/iso9660/Makefile.am

0003: check /bin/bash.exe result only if not cross-compiling
  in configury.

0004: minor warning fixes (minor casts for format string in two
  places in lib/driver/MSWindows/win32_ioctl.c and
  lib/iso9660/iso9660_fs.c .)


Ozkan Sezer <sezero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by sezero (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-20 rocky Open/ClosedOpen Closed
    2016-11-20 rocky StatusNone Done
        Assigned toNone rocky
    2016-11-19 sezero Attached File- Added 0001-stdlib.h-and-string.h-are-needed-for-malloc-strlen-a.patch, #39024
        Attached File- Added 0002-do-not-call-nm-directly-use-the-NM-variable-instead.patch, #39025
        Attached File- Added 0003-check-bin-bash.exe-result-only-if-not-cross-compilin.patch, #39026
        Attached File- Added 0004-minor-warning-fixes.patch, #39027

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code