patchCompact Disc Input and Control Library - Patches: patch #8476, Fix broken pregap handling in...

 
 

patch #8476: Fix broken pregap handling in cdda_track_firstsector

Submitter:  Robert Kausch <enzo1982>
Submitted:  Tue 03 Jun 2014 08:22:16 PM UTC
   
 
Category:  libparanoia Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  enzo1982 Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 05 Jun 2014 09:14:07 PM UTC, comment #2: 

Applied with some additional corrections and tests.

Robert Kausch <enzo1982>
Group Member
Thu 05 Jun 2014 12:43:13 AM UTC, comment #1: 

Please make the change directly on github - thanks!

And as before thanks for the patch. To paraphrase the Bellman in the Hunting of the Snark: what I say 3 times (or more), is true.

Rocky Bernstein <rocky>
Group administrator
Tue 03 Jun 2014 08:22:16 PM UTC, original submission:  

The attached patch fixes pregap handling in cdda_track_firstsector in libcdio-paranoia.

It was broken in commit c94fcc7b04... which removed special handling of track 0 (representing the pregap/hidden track one) always returning error -401 in that case. Instead, the pregap code was moved to a block handling the first track (track 1).

The patch re-adds special handling for track 0 and fixes invalid pregap handling when dealing with track 1.

Robert Kausch <enzo1982>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by enzo1982 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-06-05 enzo1982 StatusNone Done
        Open/ClosedOpen Closed
    2014-06-05 rocky Assigned toNone enzo1982
    2014-06-03 enzo1982 Attached File- Added libcdio-paranoia-toc.patch, #31499

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code