patchCompact Disc Input and Control Library - Patches: patch #8447, Patches to make...

 
 

patch #8447: Patches to make cdio_get_track_isrc work

Submitter:  Robert Kausch <enzo1982>
Submitted:  Tue 06 May 2014 03:35:40 PM UTC
   
 
Category:  libcdio Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  enzo1982 Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 07 Jun 2014 03:27:49 PM UTC, comment #5: 

Ok. Will post on libcdio-devel comments on removing BSDi and OS/2 drivers.

Rocky Bernstein <rocky>
Group administrator
Sat 07 Jun 2014 03:01:14 PM UTC, comment #4: 

Patches applied.

I marked mmc_isrc_track_read_subchannel deprecated as discussed and changed cd-info to use the new function.

And yes, I also think removing the BSDi and OS/2 drivers would be a good idea, especially if there's nobody to maintain and test them anymore.

Robert Kausch <enzo1982>
Group Member
Thu 05 Jun 2014 12:40:47 AM UTC, comment #3: 

Please apply the patches directly - thanks. As for OS/2 and BSDI, I wouldn't worry about them. We should probably remove the drivers altogether.

The person supporting BSDI has long since lost interest. As for OS/2, I think there was one patch to add the driver initially and not much after that.

Rocky Bernstein <rocky>
Group administrator
Tue 06 May 2014 08:47:57 PM UTC, comment #2: 

Here's the patch for Linux and another one for BSDi and OS/2.

Originally, I was looking to implement Linux support with a specific IOCTL or using the CDROMSUBCHNL IOCTL. Turned out though, that Linux does not have an IOCTL for reading ISRCs (even though there is one to read the MCN) and CDROMSUBCHNL does not interpret control data and so only reads the current position info.

That left the choice to either implement ISRC reading using the SG_IO IOCTL (generic SCSI command) or use the existing MMC implementation. Both should work, but I don't think it makes sense to use SG_IO here as it isn't used anywhere else in libcdio. Thus, I went the MMC way and the patch works just fine for me.

I also made a BSDi and OS2 patch, because those were the only two platforms that wouldn't support ISRC reading after Linux was done and the patches are rather trivial (using MMC once again). I didn't do any tests on those OS, though.

(file #31324, file #31325)

Robert Kausch <enzo1982>
Group Member
Tue 06 May 2014 05:43:43 PM UTC, comment #1: 

OS X patch is now attached.

It's independent of the others, i.e. works without the MMC patch.

(file #31323)

Robert Kausch <enzo1982>
Group Member
Tue 06 May 2014 03:35:40 PM UTC, original submission:  

The attached patches implement get_track_isrc in the MMC and Win32 interfaces and update the FreeBSD, AIX, NetBSD and Solaris drivers to use the MMC implementation.

The MMC patch also changes the existing mmc_isrc_track_read_subchannel to use the same implementation as the new get_track_isrc_mmc and mmc_get_track_isrc (in the same manner that get_mcn_mmc and mmc_get_mcn share the same private implementation).

The MMC patch can be applied on its own and should be applied before the Win32 and Unix patches. The Win32 patch uses mmc_get_track_isrc as a fallback in ASPI mode; the Unix patch always uses the MMC implementation on FreeBSD, AIX, NetBSD and Solaris.

The Win32 implementation was tested on Windows 7; the MMC implementation was tested on Windows 7 and PC-BSD 9.1 (FreeBSD).

It would be great to see these patches in libcdio 0.93!

I will work on patches for Linux and OS X now and post them here later.

Best regards,
Robert

Robert Kausch <enzo1982>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #31325:  libcdio-isrc_other.patch added by enzo1982 (2KiB - text/x-patch)
file #31324:  libcdio-isrc_linux.patch added by enzo1982 (1KiB - text/x-patch)
file #31323:  libcdio-isrc_osx.patch added by enzo1982 (1KiB - text/x-patch)
file #31319:  libcdio-isrc_mmc.patch added by enzo1982 (5KiB - text/x-diff)
file #31320:  libcdio-isrc_unix.patch added by enzo1982 (3KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Posted a comment)
  • -email is unavailable- added by enzo1982 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-06-07 enzo1982 StatusNone Done
        Open/ClosedOpen Closed
    2014-06-05 rocky Assigned toNone enzo1982
    2014-05-06 enzo1982 Attached File- Added libcdio-isrc_linux.patch, #31324
        Attached File- Added libcdio-isrc_other.patch, #31325
    2014-05-06 enzo1982 Attached File- Added libcdio-isrc_osx.patch, #31323
    2014-05-06 enzo1982 Attached File- Added libcdio-isrc_mmc.patch, #31319
        Attached File- Added libcdio-isrc_unix.patch, #31320
        Attached File- Added libcdio-isrc_win32.patch, #31321

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code