patchCompact Disc Input and Control Library - Patches: patch #8293, Fix minute truncation in...

 
 

patch #8293: Fix minute truncation in cdio_lsn_to_msf

Submitted by:  None
Submitted on:  Mon Jan 27 22:49:06 2014  
 
Category: libcdioPriority: 9 - Immediate
Status: DonePrivacy: Public
Assigned to: Rocky Bernstein <rocky>Originator Email: -unavailable-
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat Feb 1 05:39:03 2014, comment #1:

Thanks! Patch applied as in commit 0259081.

What was going on is that I wanted to test that error message so I reduced the number artificially small so I would trigger the error.

I forgot to set it back to its original value.

Rocky Bernstein <rocky>
Project AdministratorIn charge of this item.
Mon Jan 27 22:49:06 2014, original submission:

Minute field truncation in cdio_lsn_to_msf was - obviously accidentally - changed from 99 to 6 (!) minutes as part of this patch.

The attached patch reverts this and should fix various bugs in 0.91 and 0.92.

I was able reproduce a problem on OS X and FreeBSD where cd-info issues warnings about truncation occurring and prints out every track of an audio starting at less than 7 minutes (as expected). Disc ID calculation was wrong as well. You can probably reproduce this easily. The problem was not reproducible on Linux, however, and my patch doesn't change the correct behaviour of cd-info there.

Looking at the source, candidates for problems are (among others):

- audio playback on FreeBSD
- audio extraction on Solaris, BSDi and AIX
- mode 2 extraction on Linux, Solaris, BSDi and AIX
- subchannel extraction on BSDi

Those are some of the places where cdio_lsn_to_msf or cdio_lba_to_msf are used. There are more and I did not even check usage of other functions relying on them, so that's probably just the tip of the iceberg.

I set the priority to 9 as I think this is a major bug and might justify an immediate release of a fixed version.

Best regards,
Robert

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30394:  libcdio-0.92-msf.patch added by None (748B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by rocky (Posted a comment)
  • -unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Feb 1 05:40:04 2014rockyStatusNone=>Done
      Assigned toNone=>rocky
      Open/ClosedOpen=>Closed
    Mon Jan 27 22:49:06 2014NoneAttached File-=>Added libcdio-0.92-msf.patch, #30394

    Back to the top


    Powered by Savane 3.1-cleanup1