patchCompact Disc Input and Control Library - Patches: patch #5999, libcdio does not inform about...

 
 

patch #5999: libcdio does not inform about error while single-sector read

Submitter:  None
Submitted:  Sun 10 Jun 2007 02:04:45 PM UTC
   
 
Category:  libcdio Priority:  7 - High
Status:  Done Privacy:  Public
Assigned to:  rocky Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 16 Oct 2007 03:34:14 PM UTC, comment #1: 

Patch applied. Thanks.

Rocky Bernstein <rocky>
Group administrator
Sun 10 Jun 2007 02:04:45 PM UTC, original submission:  

irc://freenode/#xmms2, 2007-06-10 12:31:58 UTC
-*- darkk^ , seems, found the bug in libcdio
<Eclipser> darkk^, oh cool :)
<darkk^> Eclipser, if you want, look at read_blocks function
<darkk^> in libcdio, I mean
<Eclipser> file?
<darkk^> lib/cdda_interface/cddap_interface.c
<darkk^> the bug is there from the very beginning
<darkk^> http://cvs.savannah.gnu.org/viewvc/libcdio/libcdio/lib/cdda_interface/cddap_interface.c?annotate=1.5&sortby=date
<Eclipser> I'm blind to it apparently
<darkk^> it's called with i_sector = 1, cdio_read_audio_sectors returnes -1 (DRIVER_OP_ERROR), we break at line 113 out of loop and have i_sectors == 1 still
<darkk^> workaround: disable error_retry

Here is fix I suggest. Seems, it should not break anything.
Mail me if I'm wrong, please.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #13004:  libcdio-read_blocks.diff added by None (989B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rocky (Updated the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-16 rocky StatusNone Done
    2007-10-16 rocky Open/ClosedOpen Closed
    2007-10-16 rocky Assigned toNone rocky
    2007-06-10 None Attached File- Added libcdio-read_blocks.diff, #13004

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code