patchGNU Core Utilities - Patches: patch #4600, Addition of "dups" file...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4600: Addition of "dups" file utility to GNU Core Utilities

Submitter:  None
Submitted:  Sat 05 Nov 2005 06:04:54 AM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Wont Do Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed

Thu 24 Nov 2005 06:17:28 AM UTC, comment #5: 

 <a href='http://mamba.dynu.net/masterzone/oder-asians-womens-naked.html'> http://mamba.dynu.net/masterzone/oder-asians-womens-naked.html - oder asians womens naked </a> http://mamba.dynu.net/masterzone/oder-asians-womens-naked.html
 <a href='http://pivasik.dynu.net/kozel/huge-black-tits.html'> http://pivasik.dynu.net/kozel/huge-black-tits.html - huge black tits </a> http://pivasik.dynu.net/kozel/huge-black-tits.html
 <a href='http://mamba.dynu.net/masterzone/kims-free-asian-xxx.html'> http://mamba.dynu.net/masterzone/kims-free-asian-xxx.html - kims free asian xxx </a> http://mamba.dynu.net/masterzone/kims-free-asian-xxx.html
 <a href='http://pivasik.dynu.net/kozel/movies-boobs.html'> http://pivasik.dynu.net/kozel/movies-boobs.html - movies boobs </a> http://pivasik.dynu.net/kozel/movies-boobs.html
 <a href='http://mamba.dynu.net/door/fat-ugly-naked-woman.html'> http://mamba.dynu.net/door/fat-ugly-naked-woman.html - fat ugly naked woman </a> http://mamba.dynu.net/door/fat-ugly-naked-woman.html
 <a href='http://mamba.dynu.net/masterzone/fine-japanese-girls.html'> http://mamba.dynu.net/masterzone/fine-japanese-girls.html - fine japanese girls </a> http://mamba.dynu.net/masterzone/fine-japanese-girls.html
 <a href='http://wvvw.dynu.net/puzan/xxx-older-mature-women.html'> http://wvvw.dynu.net/puzan/xxx-older-mature-women.html - xxx older mature women </a> http://wvvw.dynu.net/puzan/xxx-older-mature-women.html
 <a href='http://pivasik.dynu.net/door/hi-octane-bbw.html'> http://pivasik.dynu.net/door/hi-octane-bbw.html - hi octane bbw </a> http://pivasik.dynu.net/door/hi-octane-bbw.html
 <a href='http://mamba.dynu.net/puzan/gift-for-80-year-old-italians.html'> http://mamba.dynu.net/puzan/gift-for-80-year-old-italians.html - gift for 80 year old italians </a> http://mamba.dynu.net/puzan/gift-for-80-year-old-italians.html
 <a href='http://pivasik.dynu.net/puzan/mature-chinese-women-60.html'> http://pivasik.dynu.net/puzan/mature-chinese-women-60.html - mature chinese women 60 </a> http://pivasik.dynu.net/puzan/mature-chinese-women-60.html
 <a href='http://mamba.dynu.net/green/blowjobs-oral-sex.html'> http://mamba.dynu.net/green/blowjobs-oral-sex.html - blowjobs oral sex </a> http://mamba.dynu.net/green/blowjobs-oral-sex.html
 <a href='http://pivasik.dynu.net//free-interracial-nude-pic.html'> http://pivasik.dynu.net//free-interracial-nude-pic.html - free interracial nude pic </a> http://pivasik.dynu.net//free-interracial-nude-pic.html
 <a href='http://mamba.dynu.net/puzan/broadband-mature-porn.html'> http://mamba.dynu.net/puzan/broadband-mature-porn.html - broadband mature porn </a> http://mamba.dynu.net/puzan/broadband-mature-porn.html
 <a href='http://mamba.dynu.net/puzan/free-erotic-pictures-of-mature-women.html'> http://mamba.dynu.net/puzan/free-erotic-pictures-of-mature-women.html - free erotic pictures of mature women </a> http://mamba.dynu.net/puzan/free-erotic-pictures-of-mature-women.html
 <a href='http://pivasik.dynu.net//interracial-porn-thumbs.html'> http://pivasik.dynu.net//interracial-porn-thumbs.html - interracial porn thumbs </a> http://pivasik.dynu.net//interracial-porn-thumbs.html
 <a href='http://mamba.dynu.net//dult-interracial-madrus-mpeg.html'> http://mamba.dynu.net//dult-interracial-madrus-mpeg.html - dult interracial madrus mpeg </a> http://mamba.dynu.net//dult-interracial-madrus-mpeg.html
 <a href='http://mamba.dynu.net/masterzone/thai-gogo.html'> http://mamba.dynu.net/masterzone/thai-gogo.html - thai gogo </a> http://mamba.dynu.net/masterzone/thai-gogo.html
 <a href='http://wvvw.dynu.net/kozel/big-tits-models.html'> http://wvvw.dynu.net/kozel/big-tits-models.html - big tits models </a> http://wvvw.dynu.net/kozel/big-tits-models.html
 <a href='http://pivasik.dynu.net/kozel/big-and-natural-breasts.html'> http://pivasik.dynu.net/kozel/big-and-natural-breasts.html - big and natural breasts </a> http://pivasik.dynu.net/kozel/big-and-natural-breasts.html
 <a href='http://mamba.dynu.net/vatnik/transsexual-tgp-picture-sites.html'> http://mamba.dynu.net/vatnik/transsexual-tgp-picture-sites.html - transsexual tgp picture sites </a> http://mamba.dynu.net/vatnik/transsexual-tgp-picture-sites.html
 <a href='http://pivasik.dynu.net/puzan/naked-wrestling-older-women.html'> http://pivasik.dynu.net/puzan/naked-wrestling-older-women.html - naked wrestling older women </a> http://pivasik.dynu.net/puzan/naked-wrestling-older-women.html
 <a href='http://wvvw.dynu.net/masterzone/xxx-asian-movie-samples.html'> http://wvvw.dynu.net/masterzone/xxx-asian-movie-samples.html - xxx asian movie samples </a> http://wvvw.dynu.net/masterzone/xxx-asian-movie-samples.html
 <a href='http://pivasik.dynu.net/vatnik/shemales-nude.html'> http://pivasik.dynu.net/vatnik/shemales-nude.html - shemales nude </a> http://pivasik.dynu.net/vatnik/shemales-nude.html
 <a href='http://pivasik.dynu.net/kozel/free-big-natural-tits-videos.html'> http://pivasik.dynu.net/kozel/free-big-natural-tits-videos.html - free big natural tits videos </a> http://pivasik.dynu.net/kozel/free-big-natural-tits-videos.html
 <a href='http://mamba.dynu.net/masterzone/mature-asian.html'> http://mamba.dynu.net/masterzone/mature-asian.html - mature asian </a> http://mamba.dynu.net/masterzone/mature-asian.html
 <a href='http://mamba.dynu.net/vatnik/amsterdam-shemale.html'> http://mamba.dynu.net/vatnik/amsterdam-shemale.html - amsterdam shemale </a> http://mamba.dynu.net/vatnik/amsterdam-shemale.html
 <a href='http://mamba.dynu.net/puzan/mature-over-50-galleries.html'> http://mamba.dynu.net/puzan/mature-over-50-galleries.html - mature over 50 galleries </a> http://mamba.dynu.net/puzan/mature-over-50-galleries.html
 <a href='http://mamba.dynu.net/puzan/MATURE-POST.html'> http://mamba.dynu.net/puzan/MATURE-POST.html - MATURE POST </a> http://mamba.dynu.net/puzan/MATURE-POST.html
 <a href='http://pivasik.dynu.net//uckold-interracial-sex.html'> http://pivasik.dynu.net//uckold-interracial-sex.html - uckold interracial sex </a> http://pivasik.dynu.net//uckold-interracial-sex.html
 <a href='http://mamba.dynu.net/masterzone/nude-petite-asians.html'> http://mamba.dynu.net/masterzone/nude-petite-asians.html - nude petite asians </a> http://mamba.dynu.net/masterzone/nude-petite-asians.html
 <a href='http://pivasik.dynu.net/masterzone/asian-transsexual-xxx.html'> http://pivasik.dynu.net/masterzone/asian-transsexual-xxx.html - asian transsexual xxx </a> http://pivasik.dynu.net/masterzone/asian-transsexual-xxx.html
WBR hucgaPQrRXEWUzwiF

Anonymous
Tue 08 Nov 2005 04:39:08 AM UTC, comment #4: 

Based on http://lists.gnu.org/archive/html/bug-coreutils/2005-11/msg00065.html, I am closing this patch.  Thanks for the suggestion, though, and good luck improving the utility for your own use.

Eric Blake <ericb>
Group administrator
Sun 06 Nov 2005 12:52:49 PM UTC, comment #3: 

Sorry, there was a serious problem with the handling of symbolic links
when hard linking files together.  It might be fixed now, though my test
filesystem has been destroyed by this utility when trying to link all duplicates.
Also, all appropriate text strings have been localized with _("") for use with gettext.

Anonymous
Sun 06 Nov 2005 05:39:38 AM UTC, comment #2: 

Thank you very much for your detailed evalution of the dups utility I
submitted.  It is obviously not ready for addition to GNU software, but
I did fix two things you mentioned.  It now has a changelog and the
devices are compared before hard linking.  Attached, if anyone is interested.

Anonymous
Sat 05 Nov 2005 08:09:23 PM UTC, comment #1: 

Just some constructive criticism:

- doesn't accept long option names
- doesn't accept --help and --version that every GNU util should recognise
- no ChangeLog entries included
- no texinfo documentation or help2man output
- coding style does not match the GNU coding standards
- messages should be localized with _("") for use with gettext
- comparing files one byte at a time with getc() is extremely inefficient
- it should read each file at most once and store a hash, otherwise performance is going to be horrendous (O(N^2)) when the number of files and/or the file size is large
- if the link() fails (such as two files on different volumes) it leaves things in a bad state because it's already committed to unlinking one of the files.  This is a very bad thing since it's now caused permanent data loss.  It should at the least check if they are on the same volume first before continuing, and additionally it should rename one until the link() succeeds, so that it rename it back to its original name if the link fails.

Anonymous
Sat 05 Nov 2005 06:04:54 AM UTC, original submission:  

Attached is a command line file utility for GNU Linux
that accurately displays all duplicate files listed on the
command line, with an option to hard link them.
It was written by me, George Gesslein II, in the spirit
of GNU Linux.


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #6867:  mycmp.c added by None (8KiB - application/octet-stream - dups utility with bug fix)
file #6908:  mycmp.c added by None (8KiB - application/octet-stream - updated dups utility)
file #6972:  mycmp.c added by None (7KiB - application/octet-stream - "dups" file utilitity C source code)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-08 ericb Open/ClosedOpen Closed
2005-11-08 ericb StatusNone Wont Do
2005-11-06 None Attached File- Added mycmp.c, #5444
2005-11-06 None Attached File- Added mycmp.c, #5443
2005-11-05 None Attached File- Added mycmp.c, #5439
    Carbon-Copy- Added gesslein --AT-- panix --DOT-- com

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code