patchgrep - Patches: patch #3962, More tests for foad1.sh

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3962: More tests for foad1.sh

Submitter:  Charles Levert <charles_levert>
Submitted:  Fri 29 Apr 2005 09:54:43 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Fri 29 Apr 2005 11:40:08 AM UTC, comment #3: 

Applied as CVS revision 1.7 of "tests/foad1.sh".

For posterity, given the input and pattern strings, and the --ignore-case flag, POSIX implies that:
- this logic is wrong:  if (lc(input_wchar) == lc(pattern_wchar)) ...
- this logic is wrong:  if (uc(input_wchar) == uc(pattern_wchar)) ...
- this logic is right (but could be optimized):  if (input_wchar == pattern_wchar || lc(input_wchar) == pattern_wchar || uc(input_wchar) == pattern_wchar) ...

Study the new tests to understand how this does make a difference.

Charles Levert <charles_levert>
Fri 29 Apr 2005 10:25:00 AM UTC, comment #2: 

New 2c version with additional non-reflexivity tests.

s/blindingly/blindly/ in the original summary.

BTW, these tests currently fail; that's what justifies them.

Charles Levert <charles_levert>
Fri 29 Apr 2005 10:13:44 AM UTC, comment #1: 

New 2b version with -F,-G,-E loop and improved comments.

Charles Levert <charles_levert>
Fri 29 Apr 2005 09:54:43 AM UTC, original submission:  

This patch adds -b and UTF-8 tests.  It also displays LC_ALL, but only when it has a special value.  As the patch itself contains UTF-8 encoded characters, make sure not to corrupt it before applying it.  Warning:  some characters are homographs but are still different; do not blindingly retype these tests.

Charles Levert <charles_levert>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8767:  foad1.sh.diff.charles2c added by charles_levert (5KiB - application/octet-stream - New version with additional non-reflexivity tests (warning: contains UTF-8 encoded characters))
file #8766:  foad1.sh.diff.charles2b added by charles_levert (4KiB - application/octet-stream - New version with -F,-G,-E loop and improved comments (warning: contains UTF-8 encoded characters))
file #8765:  foad1.sh.diff.charles2 added by charles_levert (4KiB - application/octet-stream - unidiff patch for this (warning: contains UTF-8 encoded characters))

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-04-29 charles_levert Open/ClosedOpen Closed
2005-04-29 charles_levert StatusNone Done
2005-04-29 charles_levert Attached File- Added foad1.sh.diff.charles2c, #4536
2005-04-29 charles_levert Attached File- Added foad1.sh.diff.charles2b, #4535
2005-04-29 charles_levert Attached File- Added foad1.sh.diff.charles2, #4534

Back to the top

Powered by Savane 3.14-ee00.
Corresponding source code