grep - Patches: patch #1939, buffer bounds problem
You are not allowed to post comments on this tracker with your current authentication level.
patch #1939: buffer bounds problem
Submitter: | None | ||
Submitted: | Sun 21 Sep 2003 03:32:58 PM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Originator Email: | -email is unavailable- |
Open/Closed: | Closed |
Tue 12 Apr 2005 02:15:39 PM UTC, comment #4: |
Julian Foad <julianfoad> |
Thu 28 Oct 2004 12:38:02 PM UTC, comment #3: I was wrong: this does fix a bug, as pointed out by Ed Smith in e-mail. He says it caused a seg fault because ibeg was being increased in the while loop when a match was found, thus reporting the wrong size to GExecute. |
Julian Foad <julianfoad> |
Thu 28 Oct 2004 01:49:37 AM UTC, comment #2: Take care not to check in the ".project" file that is also included in this patch; I assume that was unintentional. |
Julian Foad <julianfoad> |
Thu 28 Oct 2004 01:39:30 AM UTC, comment #1: AFAICT, this patch does not fix a bug, since (lim - beg) is identical to (ilim - ibeg), as evidenced in the immediately preceding loop. However, it avoids there being an unused variable, and gives consistency with a similar construct further on, and gives a cleaner style of coding. |
Julian Foad <julianfoad> |
Sun 21 Sep 2003 03:32:58 PM UTC, original submission:
|
Anonymous |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-04-12 | julianfoad | Status | None | Done | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-4b48.
Corresponding source code
Fixed in CVS. Thanks.