bugfindutils - Bugs: bug #4293, make install does not respect...

 
 

bug #4293: make install does not respect DESTDIR when generating localstatedir

Submitter:  Andreas Metzler <ametzler>
Submitted:  Sun 13 Jul 2003 09:04:37 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  Open/Closed:  Closed
Release:  None Fixed Release:  4.2.5
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 08 Nov 2004 09:58:29 PM UTC, comment #3: 

This problem is fixed in the CVS code for findutils.
To resolve your problem, you could either wait for the
next official release of findutils, or check out a copy
of the code from the CVS repository for findutils.

James Youngman <jay>
Group administrator
Sun 07 Nov 2004 08:37:28 AM UTC, comment #2: 

Jay wrote:

> Yours is a clearly-worded comment, but I don't understand > it. Firstly, the construct you're talking about appears in > the Makefile.in, but not in the Makefile.am file. Hence it > is being put into the Makefile.in file by Automake. Is
> this a bug in Automake?


The construct appears in both Makefile.am (line and Makefile.in.
grep 'mkinstalldirs \$(locals'  locate/Makefile.*
See patch attached to the bugreport, no bug in automake.

> Secondly, while I understand the physical nature of the
> change you suggest, what is its effect and why is it
> necessary?


"make DESTDIR" is designed to completely install the software under a temporary different location instead of /, it is e.g. used to build rpm or Debian packages. (During build you install in temporary directory as unprivileged user, tar it up and you are basically done.)

Currently locate/Makefile.* does not respect DESTDIR completely, with "make DESTDIR=/tmp/find install" it will put locate in /tmp/find/usr/bin/locate but it will try to generate the localstatedir (used for the locate-db) in /, i.e. try "mkdir /$localstatedir" instead of "mkdir /tmp/find/$localstatedir".

cu andreas

PS: sorry for the delayed response, but savannah had failed to send me a emailnotification on your followup.

Andreas Metzler <ametzler>
Sun 31 Oct 2004 05:10:39 PM UTC, comment #1: 

Yours is a clearly-worded comment, but I don't understand it.  Firstly, the construct you're talking about appears in the Makefile.in, but not in the Makefile.am file.  Hence it is being put into the Makefile.in file by Automake.  Is this a bug in Automake?

Secondly, while I understand the physical nature of the change you suggest, what is its effect and why is it necessary?

James Youngman <jay>
Group administrator
Sun 13 Jul 2003 09:04:37 AM UTC, original submission:  


Version: 4.1.20

locate/Makefile.* does not respect DESTDIR when generating localstatedir

Fix is straightforward, change locate/Makefile.*
- $(top_srcdir)/mkinstalldirs $(localstatedir)
+ $(top_srcdir)/mkinstalldirs $(DESTDIR)$(localstatedir)

       cu andreas

Andreas Metzler <ametzler>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #925:  fixbroken-DESTDIR.diff added by ametzler (1KiB - text/plain - patch against current CVS)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-11-19 jay Assigned toNone jay
    Open/ClosedOpen Closed
    Fixed ReleaseNone 4.2.5
2004-11-08 jay StatusNone Fixed
2004-11-07 ametzler Attached File- Added fixbroken-DESTDIR.diff, #1842

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code