bugGnash - The GNU Flash player - Bugs: bug #17049, CFLAGS wrongly used where CXXFLAGS...

 
 

bug #17049: CFLAGS wrongly used where CXXFLAGS is appropriate, plugin not installed by libtool

Submitted by:  Stefan Schweizer <genstef>
Submitted on:  Fri 07 Jul 2006 12:43:56 AM UTC  
 
Category:  None Severity:  3 - Normal
Release:  None Status:  Fixed
Privacy:  Public Assigned to:  Sandro Santilli <strk>
Open/Closed:  Closed

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 07 Jul 2006 03:10:31 PM UTC, comment #1: 

Applied, thanks!

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 07 Jul 2006 12:43:56 AM UTC, original submission:  

Hi,

CFLAGS is used instead of CXXFLAGS in some files. This results in ugly errors like:
cc1plus: warning: command line option "-Wimplicit-function-declaration" is valid for C/ObjC but not for C++

Another problem is that libtool is not used to install the plugin, resulting in strange runpaths in the installed binary.

The attached patch fixes both issues and works fine for me. Please consider applying it.

Stefan Schweizer <genstef>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #10316:  gnash-fix-cxxflags-rpath.patch added by genstef (2KiB - text/x-diff - gnash-fix-cxxflags-rpath.patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-08-01 strk StatusReady For Test => Fixed
    Open/ClosedOpen => Closed
2006-07-07 strk StatusNone => Ready For Test
    Assigned toNone => strk
2006-07-07 genstef Attached File- => Added gnash-fix-cxxflags-rpath.patch, #10316

Back to the top


Powered by Savane 3.5