bugKawa - Bugs: bug #14936, resource leak using format

 
 

bug #14936: resource leak using format

Submitter:  tk <huh>
Submitted:  Tue 08 Nov 2005 11:36:35 PM UTC
   
 
Category:  Scheme library Severity:  3 - Normal
Item Group:  Unexpected result Status:  Fixed
Privacy:  Public Assigned to:  bothner
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 14 Nov 2005 09:49:01 PM UTC, comment #4: 

Thanks.  I checked the patch into CVS.

Per Bothner <bothner>
Group administrator
Mon 14 Nov 2005 07:45:34 PM UTC, comment #3: 

corrected corrected patch. extraneous flushes flushed, ChangeLog entries added.
thanks for looking into this...


tk <huh>
Mon 14 Nov 2005 06:45:25 PM UTC, comment #2: 

Thanks.  However, a flush immediate before a close is (or should be) redundant.  So instead of:

        out.flush();
+       out.close();

could you try:

-       out.flush();
+       out.close();

as appropriate?

Per Bothner <bothner>
Group administrator
Wed 09 Nov 2005 03:34:01 PM UTC, comment #1: 

first patch missed a few cases, and wasn't formatted as a context diff.
corrected patch attached.

tk <huh>
Tue 08 Nov 2005 11:36:35 PM UTC, original submission:  


format creates gnu.mapping.OutPorts that aren't closed, so
gnu.text.WriterManager.unregister iis never called.  The result
that the ports array in WriterManager grows until the heap is
exhausted.

the attached file is a patch against the curernt CVS tree that
inserts the appropriate close calls for the temporary OutPorts.


tk <huh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #2691:  kawa.diff added by huh (9KiB - application/octet-stream - patch with extraneous flushes removed)
file #2709:  kawa.diff added by huh (5KiB - application/octet-stream - corrected patch)
file #2708:  kawa.diff added by huh (2KiB - application/octet-stream - patch for port resource leakage)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-14 bothner StatusIn Progress Fixed
    Assigned toNone bothner
    Open/ClosedOpen Closed
2005-11-14 huh Attached File- Added kawa.diff, #3106
2005-11-14 bothner StatusNone In Progress
2005-11-09 huh Attached File- Added kawa.diff, #3093
2005-11-08 huh Attached File- Added kawa.diff, #3092

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code