bugfindutils - Bugs: bug #14025, Build failure on cygwin

 
 

bug #14025: Build failure on cygwin

Submitter:  Eric Blake <ericb>
Submitted:  Wed 03 Aug 2005 03:05:37 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Compilation Failure Status:  Fixed
Privacy:  Public Assigned to:  jay
Originator Name:  Eric Blake Open/Closed:  Closed
Release:  4.2.24 Fixed Release:  4.2.25
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 09 Aug 2005 09:56:40 PM UTC, comment #2: 

I've applied this small change in the development code.  It will be included in the next release.   Thanks for your help!

James Youngman <jay>
Group administrator
Wed 03 Aug 2005 03:09:23 PM UTC, comment #1: 

I figured out the patch needed for the makefile magic:

--- lib/Makefile.am     Wed Aug  3 09:07:08 2005
************* MAINTAINERCLEANFILES =
* 24,30 **
 
 
  INCLUDES = -I../gnulib/lib -I$(top_srcdir)/gnulib/lib
! LDADD = ../gnulib/lib/libgnulib.a
 
  libfind_a_SOURCES += modetype.h nextelem.h printquoted.h listfile.h regextype.
h
  libfind_a_SOURCES += listfile.c nextelem.c extendbuf.c buildcmd.c savedirinfo.
c forcefindlib.c qmark.c printquoted.c regextype.c
--- 24,30 ----
 
 
  INCLUDES = -I../gnulib/lib -I$(top_srcdir)/gnulib/lib
! LDADD = ../gnulib/lib/libgnulib.a @INTLLIBS@
 
  libfind_a_SOURCES += modetype.h nextelem.h printquoted.h listfile.h regextype.
h
  libfind_a_SOURCES += listfile.c nextelem.c extendbuf.c buildcmd.c savedirinfo.
c forcefindlib.c qmark.c printquoted.c regextype.c

Eric Blake <ericb>
Group administrator
Wed 03 Aug 2005 03:05:37 PM UTC, original submission:  

On cygwin, compilation of the fresh 4.2.24 tarball fails, because regextype doesn't define program_name, and doesn't link with the gettext library.

gcc  -g2   -o regexprops.exe  regexprops.o regextype.o ../gnulib/lib/libgnulib.a
regextype.o: In function `get_regex_type':
/home/eblake/findutils-4.2.24/lib/regextype.c:114: undefined reference to `_libintl_gettext'
../gnulib/lib/libgnulib.a(error.o): In function `error':
/home/eblake/findutils-4.2.24/gnulib/lib/error.c:214: undefined reference to `_program_name'
../gnulib/lib/libgnulib.a(error.o): In function `error_at_line':
/home/eblake/findutils-4.2.24/gnulib/lib/error.c:274: undefined reference to `_program_name'
../gnulib/lib/libgnulib.a(xalloc-die.o): In function `xalloc_die':
/home/eblake/findutils-4.2.24/gnulib/lib/xalloc-die.c:38: undefined reference to `_libintl_gettext'
../gnulib/lib/libgnulib.a(quotearg.o): In function `gettext_quote':
/home/eblake/findutils-4.2.24/gnulib/lib/quotearg.c:168: undefined reference to `_libintl_gettext'
collect2: ld returned 1 exit status
make[3]: * [regexprops.exe] Error 1

This patch fixes the program_name complaint, but I'm not sure of the automake magic needed to fix regexprop's use of gettext to correctly pull in libintl.

Tue Jul 26 10:11:42 2005
--- lib/regexprops.c    Wed Aug  3 08:57:09 2005
*************
* 30,35 **
--- 30,37 ----
  #include "regex.h"
  #include "regextype.h"
 
+ /* Name this program was run with. */
+ char *program_name;
 
  static void output(const char *s, int escape)
  {
************* int main (int argc, char *argv[])
* 493,498 **
--- 495,502 ----
  {
    const char *up = "";
 
+   program_name = argv[0];
+
    if (argc > 1)
      up = argv[1];
 

Eric Blake <ericb>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-03 jay Open/ClosedOpen Closed
    Fixed ReleaseNone 4.2.25
2005-08-09 jay StatusNone Fixed
    Assigned toNone jay

Back to the top

Powered by Savane 3.13-4448.
Corresponding source code