taskGNU Health - Tasks: task #16398, Make age string returned by...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #16398: Make age string returned by compute_age_from_dates function translatable.

Submitter:  Feng Shu <tumashu>
Submitted:  Thu 20 Jul 2023 02:22:22 AM UTC
   
 
Should Start On:  Thu 20 Jul 2023 12:00:00 AM UTC Should be Finished on:  Thu 20 Jul 2023 12:00:00 AM UTC
Category:  Functionality Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  tumashu Percent Complete:  100%
Open/Closed:  Closed Release:  4.3.0
Module:  health Component:  Hospital Management

Tue 07 Nov 2023 10:04:32 AM UTC, comment #3: 

LGTM

Luis Falcon <meanmicio>
Group administrator
Fri 21 Jul 2023 05:32:37 PM UTC, comment #2: 

Tried zero-width length separator and looks good! :)

Updated core.py with PEP8

http://hg.savannah.gnu.org/hgweb/health/rev/190b5090149e

---

Copy the latest comments from bug #64445 on this task, so we keep all the process here.

comment #8:

>
> comment #7:
> >
> >     > 42[Y] 11[M] 9[D]
>
> looks good.


> I have update the code, and find the result is not good, looks > not beautiful, so I prefer zero widht space.


> you can update to this changeset to test:


> https://hg.savannah.gnu.org/hgweb/health/rev/dae8c77285e8




Luis Falcon <meanmicio>
Group administrator
Fri 21 Jul 2023 11:46:34 AM UTC, comment #1: 

I like Feng proposal of zero-width char:
42​y ​10​m ​23​d​

Is, behind the scenes (42<200b>y <200b>10<200b>m <200b>23<200b>d)

I think we can remove the ones prefixing the integer, just keeping those between the integer and the date element char.

42<200b>y 10<200b>m 23<200b>d

If we encounter issues, an alternative could be the latin interpunct (·) (42·y 10·m 23·d)

Enjoy the weekend!
Luis

Luis Falcon <meanmicio>
Group administrator
Thu 20 Jul 2023 02:22:22 AM UTC, original submission:  

compute_age_from_date functions can return '40y 2m 1d' style age, we should let 'y' 'm' and 'd' three strings translatable.

the before discuss is in: https://savannah.gnu.org/bugs/index.php?64445

Feng Shu <tumashu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by tumashu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-23 meanmicio CategoryNone Functionality
        StatusReady For Test Done
        Open/ClosedOpen Closed
    2023-11-07 meanmicio Percent Complete90% 100%
    2023-07-26 tumashu StatusNone Ready For Test
        Percent Complete50% 90%
    2023-07-21 meanmicio Percent Complete0% 50%
    2023-07-21 meanmicio Assigned toNone tumashu
        ReleaseNone 4.3.0

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code