taskGnash - The GNU Flash player - Tasks: task #7831, Improve garbage collector...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #7831: Improve garbage collector performance

Submitter:  Sandro Santilli <strk>
Submitted:  Wed 05 Mar 2008 10:58:11 AM UTC
   
 
Should Start On:  Tue 04 Mar 2008 11:00:00 PM UTC Should be Finished on:  Tue 04 Mar 2008 11:00:00 PM UTC
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Percent Complete:  0%
Open/Closed:  Closed Effort:  0.00

Jump to the original submission

Mon 20 Dec 2010 10:27:12 AM UTC, comment #6: 

Guess this was completed.

Sandro Santilli <strk>
Group Member
Thu 06 Mar 2008 03:30:43 PM UTC, comment #5: 

The patch was committed in head, with more code further reducing builtin functions created at startup.

Sandro Santilli <strk>
Group Member
Thu 06 Mar 2008 11:03:32 AM UTC, comment #4: 

This third patch is a futher cleanup of the previous.
It defines a generic GetterSetter that can be either
a user-defined or a native one, saving some bits of
memory for both cases and some locking for the native
case.

(file #15191)

Sandro Santilli <strk>
Group Member
Thu 06 Mar 2008 09:51:42 AM UTC, comment #3: 

Attached a cleaner patch for native getter-setter support.

As a side-effect this patch prevents getter-setters to be called
explicitly using CallMethod in v9 (abc format, currently unused).
Should be easy to fix when v9 will be active.


(file #15190)

Sandro Santilli <strk>
Group Member
Wed 05 Mar 2008 08:46:33 PM UTC, comment #2: 

During cleanups I found that the new v9 interpreter (vm/Machine.cpp) relies on getter-setter being actual as_function
so can't fully cleanup unless I also fix Machine.cpp code.

I wonder if we should take a completely different approach
and get back to manually respond to properties get/set
using the overridden get_member/set_member instead.

Sandro Santilli <strk>
Group Member
Wed 05 Mar 2008 04:20:43 PM UTC, comment #1: 

The attached patch adds support for 'native' getter-setter
and uses them for the MovieClip properties (_x,_yscale, ...).
This makes 22 builtin_function less to manage for each new
MovieClip instance, greatly reducing cost of garbage collection
(each builtin_function has to mark its prototype and the getter and setter functions, each with its own prototype..).

Will clean it up before committing.
It is known to fix bug #22461.

(file #15187)

Sandro Santilli <strk>
Group Member
Wed 05 Mar 2008 10:58:11 AM UTC, original submission:  


Garbage collector is a bootlneck for movies with many
characters in them. We should analize the reson for this
and find out possible solutions.

Sandro Santilli <strk>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #15191:  NativeProps3.patch added by strk (27KiB - text/x-patch)
file #15190:  NativeProps2.patch added by strk (22KiB - text/x-patch)
file #15187:  NativeMCprops.patch added by strk (18KiB - text/x-patch)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by strk
  • -email is unavailable- added by strk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-12-20 strk Open/ClosedOpen Closed
    2008-03-06 strk Attached File- Added NativeProps3.patch, #15191
    2008-03-06 strk Attached File- Added NativeProps2.patch, #15190
        Carbon-Copy- Added cmusick
    2008-03-05 strk Attached File- Added NativeMCprops.patch, #15187

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code