taskGNU Health - Tasks: task #16423, Support generate DICOM Modality...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #16423: Support generate DICOM Modality Worklists

Submitter:  Feng Shu <tumashu>
Submitted:  Tue 15 Aug 2023 03:54:19 AM UTC
   
 
Should Start On:  Tue 15 Aug 2023 12:00:00 AM UTC Should be Finished on:  Tue 15 Aug 2023 12:00:00 AM UTC
Category:  Functionality Priority:  5 - Normal
Status:  In Progress Privacy:  Public
Assigned to:  tumashu Percent Complete:  70%
Open/Closed:  Open Release:  4.3.0
Module:  health_orthanc Component:  Hospital Management

Jump to the original submission

Mon 13 Nov 2023 07:43:48 AM UTC, comment #20: 

Wonderful!

So now we can focus on populating the health_surgery_protocols datafile, testing and documentation.

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Mon 13 Nov 2023 02:20:44 AM UTC, comment #19: 


> We should go code freeze on Sunday to prepare 4.4


I think ok, for I have tested with the help of a DX machine a month ago,
so I think we should not faced big bug.

Feng Shu <tumashu>
Fri 10 Nov 2023 07:36:26 AM UTC, comment #18: 

Thank you, Feng!

We should go code freeze on Sunday to prepare 4.4


All the best
Luis

Luis Falcon <meanmicio>
Group administrator
Wed 08 Nov 2023 02:46:34 AM UTC, comment #17: 


comment #16:

> Feng, what's are we missing to take it to 100%?
>


The code nearly finished for me.

But, we should find a real imaging machine to test this feature.
If it works, 100% is ok.

Feng Shu <tumashu>
Tue 07 Nov 2023 10:05:12 AM UTC, comment #16: 

Feng, what's are we missing to take it to 100%?

Luis Falcon <meanmicio>
Group administrator
Wed 04 Oct 2023 05:21:19 PM UTC, comment #15: 

Fix traceback when no patient / patient ident were found.

https://hg.savannah.gnu.org/hgweb/health/rev/5014bfade670

Luis Falcon <meanmicio>
Group administrator
Mon 11 Sep 2023 08:28:31 AM UTC, comment #14: 

That's excellent, Feng!

Thank you so much. We'll use this documentation to test different scenarios and workflows.


I'll also be working on other packages documentation.



Luis Falcon <meanmicio>
Group administrator
Mon 11 Sep 2023 01:58:34 AM UTC, comment #13: 

 

> True, but in order to review the features, it's good to have functional documentation in place, so it can be used it as a guide during the testing process. Without code and/or feature documentation is hard to test.


A draft, and maybe useful for to

https://hg.savannah.gnu.org/hgweb/health/rev/6757aa6b9211

Feng Shu <tumashu>
Wed 06 Sep 2023 05:56:09 AM UTC, comment #12: 


comment #11:

>
> comment #10:
> > Great! Please document the package as much as possible.
>
> We should add document after someone review this feature, I think :-)


True, but in order to review the features, it's good to have functional documentation in place, so it can be used it as a guide during the testing process. Without code and/or feature documentation is hard to test.

>
> >
> > I suggest doing so in the community Wiki (https://en.wikibooks.org/wiki/GNU_Health/Imaging) . From there and after linting it, it will be transferred to the official doc server.
>
> en.wikibooks.org is useless for me, for I can not open it.


I have created the missing doc/index.rst template, so you can put it there. Once reviewed, we can just transfer it to the official documentation.

Thanks!

> >
> > Have a great weekend!
> > Luis
> >
> >
> >

Luis Falcon <meanmicio>
Group administrator
Wed 06 Sep 2023 12:40:17 AM UTC, comment #11: 


comment #10:

> Great! Please document the package as much as possible.


We should add document after someone review this feature, I think :-)

>
> I suggest doing so in the community Wiki (https://en.wikibooks.org/wiki/GNU_Health/Imaging) . From there and after linting it, it will be transferred to the official doc server.


en.wikibooks.org is useless for me, for I can not open it.

>
> Have a great weekend!
> Luis
>
>
>

Feng Shu <tumashu>
Fri 01 Sep 2023 09:58:33 AM UTC, comment #10: 

Great! Please document the package as much as possible.

I suggest doing so in the community Wiki (https://en.wikibooks.org/wiki/GNU_Health/Imaging) . From there and after linting it, it will be transferred to the official doc server.

Have a great weekend!
Luis



Luis Falcon <meanmicio>
Group administrator
Fri 01 Sep 2023 08:56:43 AM UTC, comment #9: 


> We'll talk before and I'm sure we can discuss it there.


This is a good idea, the Dicom standard is too complex and I don't quite understand it. I'm worried that I may make mistakes in my understanding of its tags.

Feng Shu <tumashu>
Thu 31 Aug 2023 06:25:04 AM UTC, comment #8: 


comment #7:

>
> > PS: Would you like to talk about it at GNUHealth / Orthanc Conference this September?
>
> Sorry, I don't think I can go


No worries. We'll talk before and I'm sure we can discuss it there. It's really nice work you've done!

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Thu 31 Aug 2023 04:53:39 AM UTC, comment #7: 


> PS: Would you like to talk about it at GNUHealth / Orthanc Conference this September?


Sorry, I don't think I can go

Feng Shu <tumashu>
Wed 30 Aug 2023 09:59:01 AM UTC, comment #6: 

Wow! Indeed it's a great news! Thank you for sharing! My knowledge of Chinese is not the best :P , but it looks great! :)

PS: Would you like to talk about it at GNUHealth / Orthanc Conference this September?

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Wed 30 Aug 2023 09:38:28 AM UTC, comment #5: 


> Thank you very much! I'm putting in copy our colleague S├ębastien Jogdone, creator of Orthanc. I am sure he and the Orthanc community will be happy to take a look.
>
> PS: We'll be meeting at GNUHealthCon and OrthancCon in Germany  next month.
>



good news!

I have tested with a help of Dx machine, can show worklist at the moment, it is a good news :-)










Feng Shu <tumashu>
Thu 24 Aug 2023 08:18:02 AM UTC, comment #4: 

Dear Feng Shu

Thank you very much! I'm putting in copy our colleague S├ębastien Jogdone, creator of Orthanc. I am sure he and the Orthanc community will be happy to take a look.

PS: We'll be meeting at GNUHealthCon and OrthancCon in Germany  next month.

I'm quite busy right now to push MyGNUHealth 2.0 beta by the beginning of September... after that, I'll focus on the Hospital Management component.

Happy hacking!
Luis

Luis Falcon <meanmicio>
Group administrator
Thu 24 Aug 2023 06:53:44 AM UTC, comment #3: 

I need others to  help to test this feature, better in real Modality Workstation

1. Configure orthanc and enable worklist plugins:
  
{
  /**
   * Configuration of the ModalityWorklists plugin, that can be used
   * to serve DICOM modality worklists. More information about this
   * plugin is available in the source distribution at:
   * https://bitbucket.org/sjodogne/orthanc/src/default/Plugins/Samples/ModalityWorklists/README
   **/
  "Worklists" : {
    "Enable": true,
    "Database": "/home/feng/.cache/orthanc/worklists"
  }
}

    
2. in orthanc machines, we run the below command to update worklists directory.

    script/orthanc/update_worklists_database.py -d gnuhealth -P gnuhealth -w ~/.cache/orthanc/worklists/ -s 5

3. Configure Modality Workstation to work orthanc worklist service, then thest worklists feature.

  

Feng Shu <tumashu>
Thu 24 Aug 2023 06:45:10 AM UTC, comment #2: 

More commits has been added, at the moment, I have tested with testscu.exe, worklist seem to work.


-----------------------------------------------------------------------------------------------------------------------------
02de3df8 @ tip health_orthanc: Fix error when no worklist template.                                       Feng 2023-08-24
         |
6e48ae0f o health_orthanc: init handle ReferringPhysicianName                                             Feng 2023-08-24
         |
ada45a23 o sync_orthanc_server.py: ignore error when disconnect.                                          Feng 2023-08-24
         |
505626ca o update_worklists_database.py: Add --handle-done-state arguement                                Feng 2023-08-24
         |
c7c66138 o health_orthanc: improve get_merge_id                                                           Feng 2023-08-24
         |
5737800b o health_orthanc: instance_uid of ImagingTestRequest -> merge_id, result_merge_id -> merge_id    Feng 2023-08-24
         |
3d183b13 o health_orthanc: fix create_studies can not link result                                         Feng 2023-08-23
         |
cfab530e o update_worklists_database.py: use result_merge_id                                              Feng 2023-08-23
         |
a580a083 o health_orthanc: Handle RequestedProcedureDescription                                           Feng 2023-08-23
         |
ddfcdcb3 o health_orthanc: add result_merge_id to OrthancStudy and handle it                              Feng 2023-08-23
         |
7e32278f o Update tryton/scripts/orthanc/update_worklists_database.py                                     Feng 2023-08-22
         |
afc5e9c4 o Update tryton/scripts/orthanc/update_worklists_database.py                                     Feng 2023-08-22
         |
9b496aea o health_orthanc: better handle AccessionNumber and RequestedProcedureID again.                  Feng 2023-08-22
         |
594c9e03 o health_orthanc: worklist use utf-8 by default.                                                 Feng 2023-08-22
         |
1ed421e7 o health_orthanc: Update studies field of TestResult                                             Feng 2023-08-22
         |
59438514 o Update tryton/scripts/orthanc/update_worklists_database.py                                     Feng 2023-08-21
         |
4c7fe724 o health_orthanc: Handle more dicom worklist tags.                                               Feng 2023-08-21
         |
b1bd0a19 o health_orthanc: AccessionNumber -> RequestedProcedureID                                        Feng 2023-08-21
         |
fe57ac06 o health_orthanc: improve format_dicom_person_name                                               Feng 2023-08-18
         |
2e151431 o orthanc script: argument --seconds use type = int.                                             Feng 2023-08-18
         |
7142aaa0 o sync_orthanc_server.py: add seconds arugment.                                                  Feng 2023-08-18
         |
e718868e o Fix update_worklists_database.py do not clean up files when use -r.                            Feng 2023-08-17
         |
8dad8c81 o health_orthanc: Update template field's help of OrthancWorklistTemplate again                  Feng 2023-08-17
         |
0d13ffdd o health_orthanc: Update template field's help of OrthancWorklistTemplate                        Feng 2023-08-17
         |
c1262090 o Improve tryton/scripts/orthanc/update_worklists_database.py message                            Feng 2023-08-17
         |
85f59ed4 o health_orthanc: improve worklist_template_form.xml                                             Feng 2023-08-17
         |
8c8fdb1f o health_orthanc: show worklist_text field in request form.                                      Feng 2023-08-17
         |
a3e92a50 o health_orthanc: simplify get_worklist_text.                                                    Feng 2023-08-17
         |
15c3452f o health_orthanc: OrthancWorklistTemplate add comment field.                                     Feng 2023-08-17
         |
af476384 o health_orthanc.py: change 'context' to 'my' to worklist_templation                             Feng 2023-08-16
         |
ef39a0e5 o health_orthanc.py: add 'context' to worklist_template                                          Feng 2023-08-16
         |

Feng Shu <tumashu>
Wed 16 Aug 2023 08:18:22 AM UTC, comment #1: 

https://hg.savannah.gnu.org/hgweb/health/rev/d49e9a5a2cf6

At the moment, I just test with below dcmtk command:

   findscu -W 127.0.0.1 4242 -k 0008,0050=""

We need to test with imaging devices.

Feng Shu <tumashu>
Tue 15 Aug 2023 03:54:19 AM UTC, original submission:  

orthanc can be configured as a Worklists service:

   https://book.orthanc-server.com/plugins/python.html#python-worklists

Maybe we can imporve health_orthanc to support this feature.

Feng Shu <tumashu>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #55098:  2023-08-30_17-31.png added by tumashu (664KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by tumashu (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-08-30 tumashu Attached File- Added 2023-08-30_17-31.png, #55098
    2023-08-24 meanmicio Carbon-Copy- Added -email is unavailable-
    2023-08-24 meanmicio CategoryNone Functionality
        Assigned toNone tumashu
    2023-08-24 tumashu Percent Complete50% 70%
    2023-08-16 tumashu StatusNone In Progress
        Percent Complete0% 50%
        ReleaseNone 4.3.0

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code