taskGNU Astronomy Utilities - Tasks: task #16126, astscript-radial-profile:...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #16126: astscript-radial-profile: including the --azimuth option

Submitter:  Raul Infante-Sainz <infantesainz>
Submitted:  Thu 17 Feb 2022 02:29:22 PM UTC
   
 
Should Start On:  Thu 17 Feb 2022 12:00:00 AM UTC Should be Finished on:  Thu 17 Feb 2022 12:00:00 AM UTC
Category:  Installed scripts Priority:  5 - Normal
Item Group:  New feature Status:  Done
Privacy:  Public Assigned to:  infantesainz
Percent Complete:  100% Open/Closed:  Closed
Effort:  0.00

Mon 21 Feb 2022 03:34:31 PM UTC, comment #3: 

Thanks Raul! It has been merged as Commit b4b224883b7.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Mon 21 Feb 2022 12:23:58 PM UTC, comment #2: 

Thanks a lot Mohammad. The points you commented have been included. Have a look at the commit https://gitlab.com/infantesainz/gnuastro/-/commit/bf60d0b8 (and before). Check them and merge if you consider they are good.

Raul Infante-Sainz <infantesainz>
Group Member
Fri 18 Feb 2022 12:36:03 PM UTC, comment #1: 

This is great Raul, thanks a lot ;-).

Sepideh found a bug in the radial profile script that she has Committed here. Can you also check and rebase that commit over this branch, so I merge them in together?

The reason I am suggesting this is that in line 560 of your additions, I don't see how you have accounted for the situation where no '--azimuth' is called.

In the other steps (for example the undersampling part), when that operation is not called by the user, we make a symbolic link to the output file of that step with a fixed name. So its good to follow the same convention for the azimuthal part also.

That is why I recommended to take a look at Sepideh's commit also (on properly dealing with symbolic links).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Thu 17 Feb 2022 02:29:22 PM UTC, original submission:  

Until now, the radial profile script was not able to generate azimuthal radial profiles. The reason is that the azimuthal profile of MakeProfile was added after the radial profile script was included in Gnuastro.
   
With the commit below, the necessary steps have been added in order to be able to construct azimuthal radial profiles. The option --azimuth (or -a) is used for specifying two angles that will be considered together with the radial apertures to later measure the radial profile only in such portion of the image.

https://gitlab.com/infantesainz/gnuastro/-/commit/3365df59

Pd: When filling this report in the Savannah webpage, I noticed that in the field "Category" there is a general "Installed scripts" category, but also a "astscript-radial-profile" category. I think that the radial profile script should not have such a privilege!

Raul Infante-Sainz <infantesainz>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by infantesainz (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-02-21 makhlaghi StatusIn Progress Done
        Percent Complete90% 100%
        Open/ClosedOpen Closed
    2022-02-18 makhlaghi StatusDone In Progress
        Percent Complete100% 90%

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code