taskGNU Astronomy Utilities - Tasks: task #14290, genastro script for AUTHORS -...


You are not allowed to post comments on this tracker with your current authentication level.

task #14290: genastro script for AUTHORS - weight order by numbers of lines edited?

Submitter:  Boud Roukema <boud>
Submitted:  Mon 26 Dec 2016 03:49:47 PM UTC
Should Start On:  Mon 26 Dec 2016 12:00:00 AM UTC Should be Finished on:  Mon 26 Dec 2016 12:00:00 AM UTC
Category:  Installation Priority:  1 - Later
Item Group:  Configuration file Status:  None
Privacy:  Public Assigned to:  None
Percent Complete:  0% Open/Closed:  Open
Effort:  0.00

Mon 26 Dec 2016 11:15:26 PM UTC, comment #2: 

I just remembered this Unix Kōan (Master Foo and the Hardware Designer), which is entertaining (hopefully) and related to this discussion.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Mon 26 Dec 2016 04:13:02 PM UTC, comment #1: 

This is an intriguing suggestion, but the issue you raised about the quantification by line number is also not negligible.

Its certainly worth discussing, so thanks for opening this task as a forum...

On the other side of the spectrum to your nice example, are changes that are simply done over many files/lines with a simple `grep' (on Emacs), like commit bcd59d5b (`%zu instead of %lu for printing size_t'), implementing it didn't take more than a few minutes, or require much thought. But only counting line numbers, it would be considered as a major change (57 files changed, 465 insertions, 465 deletions).

In terms of credit, I would give much more credit to that one-byte example you gave than this commit. Vladimir has made many such great corrections for example, (like this commit, or this one).

Counting commits, we would at least give both these two examples equal credit and also encourage developers to break up the commits into managable fragments as much as possible. But when counting lines, the developers might make a single commit with a large number of changes (sometimes on contextually different things).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Mon 26 Dec 2016 03:49:47 PM UTC, original submission:  

I'm copying a suggestion made in the commit comment of bug #49932, in
relation to the genauthors script for crediting authors of gnuastro.

TODO: There is no weighting option in genauthors to differentiate minor
commits from significant commits. A weighting by the number of lines
changed would partly overcome this and be easy to implement. However, the
significance of edits is not always proportional to the number of lines
edited. For example, correcting a wrong minus sign would be a single byte
edit, but possibly be of critical scientific importance. That's why I'm
rating this at the lowest priority status (1 = "later").

Boud Roukema <boud>
Group Member


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by boud (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code