taskGNU Health - Tasks: task #13888, Include taxes on from the service...


You are not allowed to post comments on this tracker with your current authentication level.

task #13888: Include taxes on from the service lines to invoice

Submitter:  Luis Falcon <meanmicio>
Submitted:  Thu 11 Feb 2016 12:38:06 PM UTC
Votes: 100
Should Start On:  Thu 11 Feb 2016 12:00:00 AM UTC Should be Finished on:  Tue 07 Feb 2017 12:00:00 AM UTC
Category:  Functionality Priority:  5 - Normal
Status:  In Progress Privacy:  Public
Assigned to:  meanmicio Percent Complete:  70%
Open/Closed:  Open Release:  3.1.0
Module:  health_services Component:  None

Wed 17 Feb 2016 10:22:41 AM UTC, comment #4: 

Update the tax summary automatically (except customer rules). Thanks  Oscar ! The rules should be computed at invoice model.

Luis Falcon <meanmicio>
Group administrator
Thu 11 Feb 2016 06:06:38 PM UTC, comment #3: 

Thanks for the feedback !

For me, that does is not optimal in terms of scalability. I see now that Tryton has the similar code in Purchase and Sales. So, for every document involving invoices (including health services model) we would have to enter all those attributes and methods related to tax rules computation. That does not scale well.

I propose that the tax rules should be calculated at invoice validation, in a similar fashion as the computation of Tax lines total.

So, at the invoice model, we have the party (and its tax rules), we have the product (and its associated taxes). So it should be feasible to compute the tax substitution rules, and will make the code much leaner and scalable.

Is it possible ?

Luis Falcon <meanmicio>
Group administrator
Thu 11 Feb 2016 01:22:38 PM UTC, comment #2: 

I re-open this issue because the solution proposed doesn't take care of the customer_tax_rule.
The best is to replicate the design of Sale.on_change_product.

Cédric Krier <cedk>
Thu 11 Feb 2016 12:43:27 PM UTC, comment #1: 

Done in changeset changeset 2389:40f8af6c84f2


Luis Falcon <meanmicio>
Group administrator
Thu 11 Feb 2016 12:38:06 PM UTC, original submission:  

For those lines in the health service document that are marked to be incoiced, product taxes should be included on the resulting invoice.

Thanks Carlos Sotelo and Fernando Sánchez for pointing it out !


Luis Falcon <meanmicio>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by cedk (Posted a comment)
  • -email is unavailable- added by csotelo (Voted in favor of this item)
  • -email is unavailable- added by meanmicio (Submitted the item)

    There are 100 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-02-11 cedk StatusDone In Progress
        Percent Complete100% 70%
    2016-02-11 csotelo Carbon-Copy- Added csotelo
    2016-02-11 meanmicio StatusNone Done
        Percent Complete0% 100%
        ReleaseNone 3.1.0

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code