patchGnash - The GNU Flash player - Patches: patch #6243, Gnash does not work in Opera

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6243: Gnash does not work in Opera

Submitted by:  Patricia Aas <psmaas>
Submitted on:  Tue 23 Oct 2007 12:45:39 PM UTC  
 
Category:  plugin Priority:  5 - Normal
Status:  Invalid Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Tue 23 Oct 2007 02:31:41 PM UTC, comment #3: 

Patricia reported HEAD works out of the box, no need to apply any patch.

Sandro Santilli <strk>
Project Member
Tue 23 Oct 2007 02:17:15 PM UTC, comment #2: 

I checked head and head does not seem to have this problem, so for now I think you can disregard this patch

Patricia Aas <psmaas>
Tue 23 Oct 2007 01:05:39 PM UTC, comment #1: 

I belive patch number 1 was already applied, please check with current head.

2007-10-15 Martin Stransky  <stransky at redhat dot com>

        * plugin/plugin.cpp: don't call NSAPI code after the fork.
          Patch from https://bugzilla.redhat.com/show_bug.cgi?id=281061.

Second is still open for discussion.

Sandro Santilli <strk>
Project Member
Tue 23 Oct 2007 12:45:39 PM UTC, original submission:  

The following patch will make Gnash work in future releases of Opera.

There are two fixes in this patch:

1. the call to getCurrentPageURL is moved so that it happens before the fork in nsPluginInstance::startProc. This is because it disrupts the synchronous call between Opera and the pluginwrapper.

2. the g_signal_connect_after to "realize" is commented out. This I am more unsure about. The callback function (realize_event) does nothing, but for some reason hooking it up causes Gnash not to get any Gdk events from the pluginwrapper. I don't know why it affects the events in this way, but it does not seem to be there for any good reason anyway, so I commented it out.

Patricia Aas <psmaas>

 

Attached Files
file #14183:  gnash.diff added by psmaas (2KiB - application/octet-stream - Patch file)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by psmaas
  • -email is unavailable- added by psmaas
  • -email is unavailable- added by psmaas (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-23 strk StatusReady For Test => Invalid
        Open/ClosedOpen => Closed
    2007-10-23 strk StatusNone => Ready For Test
    2007-10-23 psmaas Attached File- => Added gnash.diff, #14183
        Carbon-Copy- => Added csant@opera.com
        Carbon-Copy- => Added psmaas@opera.com

    Back to the top


    Powered by Savane 3.5