patchGnash - The GNU Flash player - Patches: patch #8887, Patch to correct text console...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8887: Patch to correct text console restoration in `fb-gnash`

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Sat 23 Jan 2016 01:23:31 PM UTC  
 
Category: gui-fbPriority: 5 - Normal
Status: DonePrivacy: Public
Assigned to: Sandro Santilli <strk>Open/Closed: Closed

Sat 23 Jan 2016 01:38:28 PM UTC, comment #4:

Note: This series of patch does not address the supposedly-unrelated
segmentation fault traced to fb-gnash's exit cleanup code
(predating these patches), which is remaining to be investigated.

Nutchanon Wetchasit <nachanon>
Sat 23 Jan 2016 01:35:49 PM UTC, comment #3:

Patch 3 of 3:
See the attached `0003_remove-fd-variable-check-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor decides whether if would try to
call terminal cleanup code by looking at `FBGui::_fd` variable's validity.

But in current code, function `disable_terminal()`, and `enable_terminal()`
or any other function in `FBGui` didn't really do anything meaningful with the
variable. Therefore, it was left it in `-1` value, preventing the call to
console cleanup code.

This patch removes the fd check in destructor, making the console cleanup
code always run at exit; and also removes the variable entirely, as it is
not used anymore, correcting wrong code of `disable_terminal()` in the process;
completing the fix of main issue in bug #46949.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386

(file #36147)

Nutchanon Wetchasit <nachanon>
Sat 23 Jan 2016 01:31:49 PM UTC, comment #2:

Patch 2 of 3:
See the attached `0002_call-correct-cleanup-function-in-fb-gnash.patch`.

Current Gnash's `FBGui` class's destructor which run as a part of normal exit
procedure, calls a wrong console cleanup function; it should call
`FBBui::enable_terminal()` which re-enable text console.

This patch corrects the function call.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386

(file #36146)

Nutchanon Wetchasit <nachanon>
Sat 23 Jan 2016 01:28:45 PM UTC, comment #1:

The previous post said `terminate_request` is a part of `FBGui` class,
it was mistyped, sorry. It is actually a global variable in `gnash::gui` namespace.

Nutchanon Wetchasit <nachanon>
Sat 23 Jan 2016 01:23:31 PM UTC, original submission:

Patch 1 of 3:
See the attached `0001_use-normal-exit-in-fb-gnash.patch`.

Current Gnash's `FBGui` class does not override `Gui::quitUI()` function,
and caused fb-gnash to exit abruptly via `std::exit()` when it finished
running SWF on `fscommand("quit")` or via usage of `--once` switch;
left the framebuffer console in graphics mode, which is unusable
until a special utility is run, or the machine is restarted; bug #46949.

The patch implements `FBGui::quitUI()` function, which sets
`FBGui::terminate_request` flag to `true`, signalling main loop to terminate.

Gnash: 0.8.11dev (patched against git 62cfdfe 16-Jan-2016)
Framebuffer: inteldrmfb `/dev/fb0` 1366x768 32-bit RGBA
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

Attached Files
file #36147:  0003_remove-fd-variable-check-in-fb-gnash.patch added by nachanon (2KiB - text/x-patch - Patch to remove unused `_fd` variable from `FBGui`)
file #36146:  0002_call-correct-cleanup-function-in-fb-gnash.patch added by nachanon (515B - text/x-patch - Patch to correct cleanup function call in `FBGui::~FBGui()`)
file #36145:  0001_use-normal-exit-in-fb-gnash.patch added by nachanon (927B - text/x-patch - Patch to make fb-gnash's self-termination use normal exit path instead of `std::exit()`)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Updated the item)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 29 Jan 2016 07:10:37 AM UTCstrkStatusIn Progress=>Done
      Open/ClosedOpen=>Closed
    Fri 29 Jan 2016 07:02:19 AM UTCstrkStatusNone=>In Progress
      Assigned toNone=>strk
    Sat 23 Jan 2016 01:35:49 PM UTCnachanonAttached File-=>Added 0003_remove-fd-variable-check-in-fb-gnash.patch, #36147
    Sat 23 Jan 2016 01:31:49 PM UTCnachanonAttached File-=>Added 0002_call-correct-cleanup-function-in-fb-gnash.patch, #36146
    Sat 23 Jan 2016 01:23:32 PM UTCnachanonAttached File-=>Added 0001_use-normal-exit-in-fb-gnash.patch, #36145

    Back to the top


    Powered by Savane 3.1-cleanup1