patchGnash - The GNU Flash player - Patches: patch #8840, Patch for adding more...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8840: Patch for adding more JavaScript-calls-Flash ExternalInterface callback automated tests

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Sat 26 Dec 2015 12:49:57 PM UTC
   
 
Category:  testsuite Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Sat 26 Dec 2015 02:32:35 PM UTC, comment #1: 

commit d7ed49c65aea5af9f49edae512fe152c22e2cc45

Sandro Santilli <strk>
Group Member
Sat 26 Dec 2015 12:49:57 PM UTC, original submission:  

This is a follow-up to patch #8770.

This patch adds the rest of automated test cases on Gnash's
`ExternalInterface.addCallback(methodName,instance,method)`
listed in bug #37223 comment 7 to Gnash testsuite:

  • Registration test with `method=null` and `method=undefined`: callback registration must fail to pass.
  • Registration test with `instance=null` and `instance=undefined`: callback registration must succeed to pass.
  • Test on `this` inside callback when `instance!=null`: must be user-specified Object to pass.
  • Test on `this` inside callback when `instance=null` and `instance=undefined`: must be a value equals to `null` and `undefined` to pass.
  • Test on `this` inside callback when `instance=null` and `instance=undefined`: must be an object similar to `this` in a function called via `.call(null)` (or `.call(undefined)`) to pass. (Expected to fail)
  • Long callback arguments test ("The","quick","brown","fox","jumps","over","the","lazy","dog"): must be passed correctly to pass.


Note about special cases where `instance=null` and `instance=undefined`:

`this` pointer inside the callback function should be the same as one inside
a function called via `function.call(null)` or `function.call(undefined)`,
which have following properties:

  • `typeof()` call returns "object" (not "undefined" or "null"); currently XFAIL as it gives "null".
  • having equality with `undefined`; currently PASS.
  • having equality with `null`; currently PASS.
  • not having strict equality with `undefined`; currently PASS.
  • not having strict equality with `null`; currently XFAIL as it is `null`.
  • when appended to an empty string, will result in a string "undefined"; currently XFAIL as it gives "null" string.


Gnash: 0.8.11dev (patched against git 4c03566 19-Dec-2015)
Adobe Flash Player: 11.2 r202 (11.2.202.491) NPAPI binary
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #35859:  0006_add-more-js2flash-automated-testcase.patch added by nachanon (9KiB - text/x-patch - Patch for adding more JavaScript-calls-Flash ExternalInterface tests)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-12-26 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-12-26 nachanon Attached File- Added 0006_add-more-js2flash-automated-testcase.patch, #35859

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code