patchGnash - The GNU Flash player - Patches: patch #8751, Patch to fix AudioDecoderSimple's...


You are not allowed to post comments on this tracker with your current authentication level.

patch #8751: Patch to fix AudioDecoderSimple's code comment regarding 8-bit PCM audio codec

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Wed 23 Sep 2015 10:44:59 AM UTC
Category:  sound Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Wed 23 Sep 2015 01:48:49 PM UTC, comment #2: 

Pushed as c0e274dbcea978e5a6dc41e3faf3e0196f8660b1, thanks.

Sandro Santilli <strk>
Group Member
Wed 23 Sep 2015 10:47:23 AM UTC, comment #1: 

Note (for the record):
This patch was made against Gnash 0.8.11dev (git 516a6ca 15-Sep-2015).

Nutchanon Wetchasit <nachanon>
Wed 23 Sep 2015 10:44:59 AM UTC, original submission:  

This is a follow-up to patch #8747.

Gnash's AudioDecoderSimple has a working 8-bit PCM sound decoder implementation.
But inside the class, there are some wrong code comments which falsely stated
that Flash's 8-bit PCM audio was a signed PCM format. (It is unsigned PCM,
according to what the code implements, and a test)

This patch fixes the wrong comments, so it won't cause any further confusion.

Nutchanon Wetchasit <nachanon>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34961:  0009_fix-audiodecoder-simple-pcm-u8-code-comment.patch added by nachanon (1KiB - text/x-patch - Patch for fixing 8-bit PCM audio comment in AudioDecoderSimple)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-23 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-09-23 nachanon Attached File- Added 0009_fix-audiodecoder-simple-pcm-u8-code-comment.patch, #34961

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code