patchGnash - The GNU Flash player - Patches: patch #8736, Hack to workaround PCM embeded...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8736: Hack to workaround PCM embeded sound incremental decoding problem

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Wed 09 Sep 2015 01:24:36 PM UTC
   
 
Category:  sound Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  strk Open/Closed:  Closed

Wed 09 Sep 2015 01:36:19 PM UTC, comment #1: 

Thanks, pushed as b7dbb23d8f28310d2ce15b8a575ac44bd17626eb

Sandro Santilli <strk>
Group Member
Wed 09 Sep 2015 01:24:36 PM UTC, original submission:  

Current embeded PCM sound decoder (both FFmpeg and GStreamer backend)
have some problem regarding incremental decoding. The problem surfaced
when the decoding block size is not a multiple of PCM frame size; resulting
in sample misalignment, producing screech sound (bug #45722).

This patch works around the problem by requesting the decoder to decode sound
in a block size of 65536 bytes, which is multiple of both 2-byte (16-bit mono)
and 4-byte (16-bit stereo) PCM frame. (The original block size was 65535,
which was not a multiple of frame size in 16-bit PCM encoding).

See the attached `0001_use-frame-aligned-pcm-sound-decoding-chunk.patch`.

Gnash: 0.8.11dev (patched against git c969f9d 8-Sep-2015)
SDL: libsdl1.2debian 1.2.15-5 (debian)
libAV: libavcodec53 6:0.8.17-1 (debian), libavformat53 6:0.8.17-1 (debian), libavutil51 6:0.8.17-1 (debian), libav-tools 6:0.8.10-1 (debian)
GStreamer: libgstreamer0.10-0 0.10.36-1.2 (debian)
CSound: libcsound64-5.2 1:5.17.11~dfsg-3 (debian)
System: Debian GNU/Linux 7.0 Wheezy i386

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #34841:  0001_use-frame-aligned-pcm-sound-decoding-chunk.patch added by nachanon (787B - text/x-patch - Patch to make Gnash embeded sound handler read audio in frame-aligned 64 KiB chunk)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-09 strk StatusNone Done
        Assigned toNone strk
        Open/ClosedOpen Closed
    2015-09-09 nachanon Attached File- Added 0001_use-frame-aligned-pcm-sound-decoding-chunk.patch, #34841

    Back to the top

    Powered by Savane 3.14-3b9d.
    Corresponding source code