patchGnash - The GNU Flash player - Patches: patch #8167, ffmpeg handler can't play AAC...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8167: ffmpeg handler can't play AAC (e.g. youtube)

Submitter:  Gabriele Giacone <gg0>
Submitted:  Thu 22 Aug 2013 01:49:07 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  gg0 Open/Closed:  Closed

Jump to the original submission

Wed 04 Sep 2013 08:44:09 PM UTC, comment #7: 

Thanks for reviewing

 Gabriele Giacone <gg0>
Group Member
Wed 04 Sep 2013 08:41:07 PM UTC, comment #6: 

Gabriele, isn't this done ?

 Sandro Santilli <strk>
Group Member
Fri 23 Aug 2013 03:02:18 PM UTC, comment #5: 

avcodec version 53.25.0 can play AAC just fine.
This is the version installed on Ubuntu 12.04 and Debian Wheezy (stable)

This branch works fine for me, only problem is with the RECOMMENDED line which is needlessly recommending somehitng to me.

https://github.com/strk/gnash/tree/resample2

 Sandro Santilli <strk>
Group Member
Thu 22 Aug 2013 10:14:10 AM UTC, comment #4: 

there's a bug in your AudioResamplerFfmpeg::~AudioResamplerFfmpeg.
A {} block is missing, so avresample_free(&_context); is always called, even if _context is null

Could you fix this in your branch ?

Sandro Santilli <strk>
Group Member
Thu 22 Aug 2013 09:19:17 AM UTC, comment #3: 

I think in absence of libswresample/libavresample the code should behave as before, that is (gg0 said) using the internal (limited) resampler. RECOMMENDED would be fine, with an indication of what would be missing by not following the recommandation.

 Sandro Santilli <strk>
Group Member
Thu 22 Aug 2013 09:17:10 AM UTC, comment #2: 

It is. All resampling conversions would be done by libswresample (ffmpeg) or libavresample (libav) dedicated libraries.

 Gabriele Giacone <gg0>
Group Member
Thu 22 Aug 2013 09:00:55 AM UTC, comment #1: 

Does this patch introduce a new dependency ?
I'm now getting:

          ERROR: No libswresample/libavresample development package installed!
                 You can install libswresample from http://ffmpeg.org
                 or .deb users: apt-get install libavresample-dev
                 or reconfigure with --enable-media=gst


Is that intentional ? (it used to build fine before)

 Sandro Santilli <strk>
Group Member
Thu 22 Aug 2013 01:49:07 AM UTC, original submission:  


As said at http://lists.gnu.org/archive/html/gnash-dev/2013-08/msg00002.html

available here https://github.com/gg0/gnash/commits/resample

Added minimum supported ffmpeg version (debian stable one) bump.

 Gabriele Giacone <gg0>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by gg0 (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-09-04 gg0 StatusNone Done
        Assigned toNone gg0
        Open/ClosedOpen Closed

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-da57.
    Corresponding source code