patchGNU Zile (Zile is Lossy Emacs) - Patches: patch #8007, Use posix.pipeline

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8007: Use posix.pipeline

Submitter:  Reuben Thomas <rrt>
Submitted:  Tue 09 Apr 2013 11:45:00 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Thu 11 Apr 2013 09:38:02 PM UTC, comment #4: 

I've filed a bug against luaposix: https://github.com/luaposix/luaposix/issues/81

 Reuben Thomas <rrt>
Group administrator
Thu 11 Apr 2013 08:51:13 PM UTC, comment #3: 

After investigation, it seems there's a bug in the way posix.pipeline saves and restores stdout. I can't see what it is at present.

I've updated the patch to use single quotes so it doesn't confuse the Lisp parser.

(file #27845)

 Reuben Thomas <rrt>
Group administrator
Thu 11 Apr 2013 01:44:27 PM UTC, comment #2: 

Is the bogus output going to stderr, i.e. perhaps the redirect 2>&1 isn't working for some reason?

 Reuben Thomas <rrt>
Group administrator
Thu 11 Apr 2013 03:26:11 AM UTC, comment #1: 

Hi Reuben,

Thanks for the patch!

I've cleaned up and committed my patch queue on the Zile lua branch to make zmacs run correctly on stdlib-35 (unreleased!) and luaposix-5.1.28 (from master, after my bugfix).

After applying your patch, shell-command still works correctly, but shell-command-on-region screws up the terminal somehow.  Please fix and resubmit!

Cheers,
Gary

 Gary V. Vaughan <gary>
Group administrator
Tue 09 Apr 2013 11:45:00 AM UTC, original submission:  

This patch uses posix.pipeline to simplify shell-command-on-region.

pipe_command becomes show_shell_output, as for shell-command we simply use io.shell.

 Reuben Thomas <rrt>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #27845:  use_pipeline.patch added by rrt (3KiB - text/x-diff - Updated patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gary (Posted a comment)
  • -email is unavailable- added by rrt (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-11 rrt Attached File- Added use_pipeline.patch, #27845
    2013-04-11 rrt Attached File#27826 Removed
    2013-04-09 rrt Attached File- Added use_pipeline.patch, #27826

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.14-f13d.
    Corresponding source code