patchGNU Source Installer - Patches: patch #6550, "Choose" as default...


You are not allowed to post comments on this tracker with your current authentication level.

patch #6550: "Choose" as default button while selecting packages

Submitted by:  Nicola Fontana <ntd>
Submitted on:  Mon 23 Jun 2008 02:56:41 PM UTC
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  sick_soul Open/Closed:  Open
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Wed 25 Jun 2008 09:58:01 PM UTC, comment #4: 

applied, available in latest CVS build.

Claudio Fontana <sick_soul>
Project Administrator
Tue 24 Jun 2008 10:25:09 PM UTC, comment #3: 

I thought about this for a while, and it does feel better
this way. I am integrating this change.

Claudio Fontana <sick_soul>
Project Administrator
Mon 23 Jun 2008 05:02:07 PM UTC, comment #2: 

Ok, next time I'll use a proper patch format.

I like to have a default button because of user interface consistency. With the default keybindings you could still enter in the directories using <SHIFT><SPACE>, although I don't know why it is not cited in the documentation.

Nicola Fontana <ntd>
Mon 23 Jun 2008 04:14:18 PM UTC, comment #1: 

As for the diff format, the best way to submit patches
to me for inclusion would be to make p0 or p1 unified
diffs against the latest CVS tree, with top srcdir
sourceinstall2, using diff -Naupr

But for out of tree patches restricted to a certain
component (example: sourceinstall-gtk), it is probably
ok to generate the changeset by setting the
top srcdir to the specific component directory, as
users can apply it easily to the official releases.

I think that in any case it would be better not to
include the .po changes, as those changes can make it
difficult to apply the patch to a later version with
different line numbers in the .po files.
Those files should be automatically updated during
the build process anyway.

Regarding the feature itself, I find it useful to
start browsing directories with the arrow keys
and ENTER, and this change would choose the
directory instead. But I can see your use case too.

Claudio Fontana <sick_soul>
Project Administrator
Mon 23 Jun 2008 02:56:41 PM UTC, original submission:  

It'll be useful to have [Choose] as the default response: this allows to double-click on the package name or press <ENTER>.

I attached a patch (hopefully in the right format) that does the job.

Nicola Fontana <ntd>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #15916:  default-choice.patch added by ntd (4KiB - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by sick_soul (Posted a comment)
  • -email is unavailable- added by ntd (Submitted the item)
  • -email is unavailable- added by ntd

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.





    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-06-25 sick_soul StatusIn Progress => Done
    2008-06-24 sick_soul Priority5 - Normal => 3 - Low
        StatusNone => In Progress
        Assigned toNone => sick_soul
    2008-06-23 ntd Attached File- => Added default-choice.patch, #15916
        Carbon-Copy- => Added ntd

    Back to the top

    Powered by Savane 3.9