patchGnash - The GNU Flash player - Patches: patch #6495, [PATCH] paused widget for GTK+

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6495: [PATCH] paused widget for GTK+

Submitter:  Robert Millan <robertmh>
Submitted:  Thu 24 Apr 2008 04:03:04 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Jump to the original submission

Sun 27 Apr 2008 10:06:16 AM UTC, comment #10: 

Thank you!  Maybe I can do the KDE one, if I find time for that.  But I don't promise anything ;-)

Robert Millan <robertmh>
Sun 27 Apr 2008 09:50:37 AM UTC, comment #9: 

Seems fine to me, so committed.

There's some variation in coding style, but I think most people are agreed that 'if' statements that aren't on one line should have braces. And sticking to the indentation style of the file is also good (yes, I know some files have several different ones...)

Anyway, I'll close this patch now it's in, but if you'd like to work on improvements, keep the patches coming :)

Benjamin Wolsey <bwy>
Group Member
Sat 26 Apr 2008 09:56:40 PM UTC, comment #8: 

I forgot to move the Gui declarations to "protected:" section like Sandro told me.  Just fixed.

Does it look good now?


(file #15533)

Robert Millan <robertmh>
Sat 26 Apr 2008 12:00:34 PM UTC, comment #7: 

New patch.  Fixes the pointer handling stuff, resynced with HEAD.

Notice that "startStopped" doesn't currently work on HEAD (it's simply ignored), but this regression isn't introduced with my patch (I verified).


(file #15529)

Robert Millan <robertmh>
Sat 26 Apr 2008 07:20:47 AM UTC, comment #6: 

It looks like initializing pointer members in the constructor
to 0 fixes the segfault here.
Note that the callbacks for prefs I didn't initialize.

Sandro Santilli <strk>
Group Member
Sat 26 Apr 2008 07:12:11 AM UTC, comment #5: 

The new patch segfaults:

gnash -x1 <a movie>

RcInitFile::parseFile: couldn't open file: /etc/gnashrc
RcInitFile::parseFile: couldn't open file: /usr/local/etc/gnashrc
RcInitFile: parsing /home/strk/.gnashrc

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1235257664 (LWP 10871)]
0xb710b7fc in g_type_check_instance_cast () from /usr/lib/libgobject-2.0.so.0
(gdb) bt
#0  0xb710b7fc in g_type_check_instance_cast () from /usr/lib/libgobject-2.0.so.0
#1  0x08111dc0 in gnash::GtkGui::stopHook (this=0x81dee70) at /home/strk/src/gnash/gnash-head/gui/gtk.cpp:2272
#2  0x080f9b00 in gnash::Gui::stop (this=0x81dee70) at /home/strk/src/gnash/gnash-head/gui/gui.cpp:856

Sandro Santilli <strk>
Group Member
Fri 25 Apr 2008 09:44:22 PM UTC, comment #4: 

New patch with the doxygen bits, diffed against HEAD.


(file #15524)

Robert Millan <robertmh>
Fri 25 Apr 2008 04:42:31 PM UTC, comment #3: 

Here's a new patch.  General cleanup (including your comment on IRC) and fixes a size problem when using rc startStopped option in combination with youtube.

Still missing the documentation part strk requested (will look into that later).


(file #15519)

Robert Millan <robertmh>
Thu 24 Apr 2008 07:27:31 PM UTC, comment #2: 

What I was thinking for the standalone was, instead of packing the _drawingArea directly in _vbox, to pack a container (a GtkBin, the simplest, would probably do), and then to add _drawingArea to the GtkBin.

The GtkBin would then always be accessible as the parent of _drawingArea, so wouldn't necessarily need to be a member of the class (though it might be better if it is).

We could then use gtk_container_set_default_size to size _drawingArea so that it can be shrunk (impossible at the moment). And it would be easy to replace _drawingArea with a pause widget.

Not sure what would happen to key events in the plugin, and the fullscreen code would need a bit of reworking (but not much).

Benjamin Wolsey <bwy>
Group Member
Thu 24 Apr 2008 04:03:04 PM UTC, comment #1: 

This item has been reassigned from the project Gnash - The GNU Flash player bugs tracker to your tracker.

The original report is still available at bugs #23038

Following are the information included in the original report:

[field #0]                  Item ID: 23038
[field #1]                 Group ID: 8191
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: gui-gtk
[field #10]             Submitted by: robertmh
[field #11]              Assigned to: None
[field #12]             Submitted on: Thursday 04/24/08 at 17:59
[field #13]                  Summary: [PATCH] paused widget for GTK+
[field #14]      Original Submission:
Hi!

I implemented paused widget support for the GTK+ GUI, as described in http://wiki.gnashdev.org/PausedWidget (first option).

Many thanks to Benjamin and strk from their assistance on IRC.

[field #16]               Item Group: None
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: None
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #58]     Custom Select Box #1: None
[field #59]     Custom Select Box #2: None
[field #60]     Custom Select Box #3: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

Benjamin Wolsey <bwy>
Group Member
Thu 24 Apr 2008 04:03:04 PM UTC, original submission:  


Hi!

I implemented paused widget support for the GTK+ GUI, as described in http://wiki.gnashdev.org/PausedWidget (first option).

Many thanks to Benjamin and strk from their assistance on IRC.

Robert Millan <robertmh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #15533:  paused_widget.diff added by robertmh (5KiB - text/x-diff)
file #15529:  paused_widget.diff added by robertmh (5KiB - text/x-diff - Fixes the pointer handling stuff, resynced with HEAD)
file #15524:  paused_widget.diff added by robertmh (4KiB - text/x-diff)
file #15519:  paused_widget.diff added by robertmh (4KiB - text/x-diff)
file #15516:  paused_widget.diff added by robertmh (4KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by bwy (Posted a comment)
  • -email is unavailable- added by robertmh (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-04-27 bwy StatusNone Done
        Open/ClosedOpen Closed
    2008-04-26 robertmh Attached File- Added paused_widget.diff, #15533
    2008-04-26 robertmh Attached File- Added paused_widget.diff, #15529
    2008-04-25 robertmh Attached File- Added paused_widget.diff, #15524
    2008-04-25 robertmh Attached File- Added paused_widget.diff, #15519
    2008-04-24 bwy Reassign itemGnash - The GNU Flash player, bug #23038 Gnash - The GNU Flash player, patch #6495

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code