Gnash - The GNU Flash player - Patches: patch #6158, Make set debuglog work
You are not allowed to post comments on this tracker with your current authentication level.
patch #6158: Make set debuglog work
Submitter: | Benjamin Wolsey <bwy> | ||
Submitted: | Mon 20 Aug 2007 08:59:56 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Tue 21 Aug 2007 11:04:35 AM UTC, comment #11: |
Benjamin Wolsey <bwy> |
Mon 20 Aug 2007 11:26:42 PM UTC, comment #10: committed in both branches. |
Sandro Santilli <strk> |
Mon 20 Aug 2007 07:23:43 PM UTC, comment #9: Fixes a typo, matches the whole username if there's no slash (following POSIX) and makes expandPath (not expandTilde) private. |
Benjamin Wolsey <bwy> |
Mon 20 Aug 2007 06:09:49 PM UTC, comment #8: Applied in both head and 0.8.1 branch. Thanks ! |
Sandro Santilli <strk> |
Mon 20 Aug 2007 05:15:59 PM UTC, comment #7: Patch attached. |
Benjamin Wolsey <bwy> |
Mon 20 Aug 2007 04:29:20 PM UTC, comment #6: Ben, your patch works fine for me, but will commit the one with expandTilde function (missed attachment?) |
Sandro Santilli <strk> |
Mon 20 Aug 2007 02:49:12 PM UTC, comment #5: I've just been putting it into a function expandTilde for that very reason. The first patch is there in case there are any dreadful errors in the code (like trying to modify const char ...)
|
Benjamin Wolsey <bwy> |
Mon 20 Aug 2007 02:26:13 PM UTC, comment #4: Another note: it was disturbing (not your fault) that when I tried ~/gnash.log I didn't get any ERROR, would have expected something like: 'ERROR: can't create ~/gnash.log: no such file or directory'
|
Sandro Santilli <strk> |
Mon 20 Aug 2007 02:23:24 PM UTC, comment #3: No, the only reason I was wondering about was for the testcase, but I used /tmp/gnash-dbg.log to avoid problems with it...
|
Sandro Santilli <strk> |
Mon 20 Aug 2007 01:28:55 PM UTC, comment #2: Well, you asked for it...
|
Benjamin Wolsey <bwy> |
Mon 20 Aug 2007 10:42:54 AM UTC, comment #1: Committed and added testing.
|
Sandro Santilli <strk> |
Mon 20 Aug 2007 08:59:56 AM UTC, original submission:
A one liner to make "set debuglog <path_to_file>" in .gnashrc work when set.
|
Benjamin Wolsey <bwy> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-08-21 | bwy | Attached File | - | Added getpwnamcheck.patch, #13752 | |
2007-08-20 | bwy | Attached File | - | Added tilde_bugfix.patch, #13742 | |
2007-08-20 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2007-08-20 | bwy | Attached File | - | Added expand_tilde.patch, #13741 | |
2007-08-20 | bwy | Attached File | - | Added expand_tilde_on_unix_first_go.patch, #13739 | |
2007-08-20 | strk | Status | None | Ready For Test | |
Assigned to | None | strk | |||
2007-08-20 | bwy | Attached File | - | Added make_log_work.patch, #13737 |
Powered by Savane 3.13-f8d8.
Corresponding source code
If pwd.h found but not getpwnam it expands tilde only if HOME is set in env, the passwd part doesn't build.
It works as long as the configure tests are good.
(file #13752)