Gnash - The GNU Flash player - Patches: patch #6081, Finish implemention of array.sort...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6081: Finish implemention of array.sort using AS comparison function
Submitter: | None | ||
Submitted: | Sat 07 Jul 2007 09:40:51 PM UTC | ||
Category: | ActionScript | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Originator Email: | -email is unavailable- |
Open/Closed: | Closed |
Wed 18 Jul 2007 11:22:00 AM UTC, comment #3: |
Sandro Santilli <strk> |
Fri 13 Jul 2007 01:15:03 AM UTC, comment #2: Committed, adding a test about 'this', which is failing in Gnash.
|
Sandro Santilli <strk> |
Fri 13 Jul 2007 01:09:11 AM UTC, comment #1: No, there's no way to avoid it currently. We always need a 'this' pointer when we call a function. Try tracing 'this' from within the comparator function to see what it should be pointing at.
|
Sandro Santilli <strk> |
Sat 07 Jul 2007 09:40:51 PM UTC, original submission:
I had a quick go at finishing the array.sort(compareFunction) implementation since most of the work had already been done. I also added a test for it in the array.as (see attached patch).
|
Anonymous |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-07-18 | strk | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2007-07-13 | strk | Status | None | In Progress | |
Assigned to | None | strk | |||
2007-07-07 | None | Attached File | - | Added array_cmp_sort.patch, #13267 |
Powered by Savane 3.13-758e.
Corresponding source code
I postponed working on 'this' as it takes much more thinking.
For now, your patch is in. Thanks.
See task #7093 for the 'this' thing.