Gnash - The GNU Flash player - Patches: patch #5620, about "display_list" and...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5620: about "display_list" and "sprite_instance::advance_sprite" implementation
Submitter: | Zou Lunkai <zoulunkai> | ||
Submitted: | Thu 07 Dec 2006 01:12:28 AM UTC | ||
Category: | core | Priority: | 5 - Normal |
Status: | In Progress | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Discussion locked!
Jump to the original submission
Thu 14 Jun 2007 01:11:37 AM UTC, comment #25: |
Zou Lunkai <zoulunkai> |
Wed 13 Jun 2007 05:38:36 PM UTC, comment #24: Zou, I think this item was obsoleted by the TimelineControl wiki page and all the effort brought there, right ?
|
Sandro Santilli <strk> |
Sat 10 Feb 2007 01:40:20 PM UTC, comment #23: I committed my patch for now. Please give higher priority to bug #19020 as it is a regression. |
Sandro Santilli <strk> |
Sat 10 Feb 2007 12:57:54 PM UTC, comment #22: Attached a patch that fixes this specific case and introduces no further failure in current testcases.
|
Sandro Santilli <strk> |
Sat 10 Feb 2007 12:21:23 PM UTC, comment #21: The character class has a 'restart' method. Maybe that's what we need to simalate a completely new placement (we might call ::construct from ::restart, for example). Want to give this a try ?
|
Sandro Santilli <strk> |
Sat 10 Feb 2007 05:46:18 AM UTC, comment #20: Done
|
Zou Lunkai <zoulunkai> |
Sat 10 Feb 2007 02:48:46 AM UTC, comment #19: build an imaginary testcase like this:
|
Zou Lunkai <zoulunkai> |
Sat 10 Feb 2007 01:53:56 AM UTC, comment #18: Follow comment #12.
yes, I still think so. But we should consider that characters instanciated in first frame could be removed by tags in later frame. They could keep alive only if they were not removed by later tags.
yes, I still think so.
|
Zou Lunkai <zoulunkai> |
Sun 14 Jan 2007 09:09:17 AM UTC, comment #17:
Yes.
|
Zou Lunkai <zoulunkai> |
Fri 12 Jan 2007 02:07:10 PM UTC, comment #16: Sorry for the confusion, nothing to do with constant pool,
|
Sandro Santilli <strk> |
Fri 12 Jan 2007 12:14:44 PM UTC, comment #15: The failure seems due to a Constants lookup bug actually.
|
Sandro Santilli <strk> |
Fri 12 Jan 2007 11:37:43 AM UTC, comment #14: Added to the testsuite, and expect the only failure.
|
Sandro Santilli <strk> |
Fri 12 Jan 2007 10:27:27 AM UTC, comment #13: Another insane testcase.
|
Zou Lunkai <zoulunkai> |
Tue 02 Jan 2007 03:49:36 AM UTC, comment #12: Brief summary of a discussion about loop frame advancement between me and Zou:
|
Sandro Santilli <strk> |
Fri 29 Dec 2006 09:47:56 AM UTC, comment #11: reopened for Zou request... let's keep this upen until we have enough testcases. |
Sandro Santilli <strk> |
Thu 28 Dec 2006 01:46:45 AM UTC, comment #10: Closing this again as the latest patch in sprite_instance::add_display_object and place_object_2::execute fixed the bogus symptom this patch was bogusly trying to fix. |
Sandro Santilli <strk> |
Tue 26 Dec 2006 03:10:11 PM UTC, comment #9: commited and updated runner, please check |
Sandro Santilli <strk> |
Mon 25 Dec 2006 05:38:41 AM UTC, comment #8: Attaches the source of the test file: loop_test.c
|
Zou Lunkai <zoulunkai> |
Sun 24 Dec 2006 08:11:07 PM UTC, comment #7: I'm reopening this because the committed fix broke elvis
|
Sandro Santilli <strk> |
Tue 12 Dec 2006 01:14:25 AM UTC, comment #6: Added testcase, and verified it would fail w/out your patch. |
Sandro Santilli <strk> |
Fri 08 Dec 2006 02:12:49 PM UTC, comment #5: Yes, your patch fixes this. Thanks!
|
Sandro Santilli <strk> |
Fri 08 Dec 2006 02:01:26 PM UTC, comment #4: No, actually I see 2.5 seconds the black circle over the red rectangle, then a very short period of switching, and suddenly the 2.5 seconds of black circle over red again.
|
Sandro Santilli <strk> |
Fri 08 Dec 2006 12:49:36 AM UTC, comment #3:
Yes, no problem.
No, I am using gnash_release_0.7.2
|
Zou Lunkai <zoulunkai> |
Thu 07 Dec 2006 09:37:52 AM UTC, comment #2: BTW, can we include your testcase in our testsuite ? |
Sandro Santilli <strk> |
Thu 07 Dec 2006 09:35:05 AM UTC, comment #1: I already see the depths swap with current Gnash version,
|
Sandro Santilli <strk> |
Thu 07 Dec 2006 01:12:28 AM UTC, original submission:
I paste a patch file about the "sprite_instance::advance_sprite(float delta_time)" member function in "sprite_instance.cpp". I think the "execute_frame_tags(m_current_frame)" function should not be re-executed for the first frame when play the flash movie again, because its display_list has been already retrieved.
|
Zou Lunkai <zoulunkai> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 24 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-06-14 | zoulunkai | Open/Closed | Open | Closed | |
Discussion Lock | None | Locked | |||
2007-02-10 | strk | Attached File | - | Added sprite.frame0.patch, #11956 | |
2007-02-10 | zoulunkai | Discussion Lock | Locked | None | |
2007-02-10 | zoulunkai | Discussion Lock | None | Locked | |
2007-02-10 | zoulunkai | Discussion Lock | Locked | None | |
2007-02-10 | zoulunkai | Category | None | core | |
Priority | 2 | 5 - Normal | |||
Discussion Lock | None | Locked | |||
2007-01-14 | strk | Attached File | #11469 | Removed | |
2007-01-14 | strk | Attached File | #11468 | Removed | |
2007-01-14 | zoulunkai | Attached File | - | Added place_and_remove_object_insane_test_update.c, #11738 | |
2007-01-12 | zoulunkai | Attached File | - | Added place_and_remove_object_insane_test.c, #11728 | |
2006-12-29 | strk | Status | Done | In Progress | |
Open/Closed | Closed | Open | |||
2006-12-28 | strk | Open/Closed | Open | Closed | |
2006-12-25 | zoulunkai | Attached File | - | Added loop_test.c, #11596 | |
2006-12-24 | strk | Open/Closed | Closed | Open | |
2006-12-12 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2006-12-08 | strk | Status | None | Ready For Test | |
2006-12-07 | zoulunkai | Attached File | - | Added advance_sprite.txt, #11467 | |
Attached File | - | Added sprite_test.swf, #11468 | |||
Attached File | - | Added sprite_test.fla, #11469 |
Powered by Savane 3.13-4b48.
Corresponding source code
OK, close this item. For more reference, see "Timeline control" on wiki.