patchphpGroupWare - Patches: patch #5387, patch for adding support of svn in...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5387: patch for adding support of svn in the api and more

Submitter:  Caeies <Caeies>
Submitted:  Wed 13 Sep 2006 10:08:40 AM UTC
Category:  filemanager Priority:  5 - Normal
Item Group:  SVN trunk (dev code) Status:  In Progress
Privacy:  Public Assigned to:  Caeies
Open/Closed:  Open

Tue 24 Oct 2006 02:07:35 PM UTC, comment #4: 

Sorry I was a little too eager to close this one

Dave Hall <skwashd>
Group administrator
Tue 24 Oct 2006 01:59:55 PM UTC, comment #3: 

This has been applied, closing

Dave Hall <skwashd>
Group administrator
Tue 19 Sep 2006 11:50:12 AM UTC, comment #2: 

Hi Dave,

Does the filemanage/templates/base/css/base.css automatically included or should we take special action ?

ok for phpdoc into the new SVN classes

For the split, That's not third party code, then it follow the other equivalent class (http_dav_client IIRC) which use the same structure. I don't see any pertinent reasons for moving it out of the class, since it's purly internal ...



Caeies <Caeies>
Group administrator
Sun 17 Sep 2006 01:32:09 AM UTC, comment #1: 

This looks good.

A few suggestions

Move the diff CSS to filemanage/templates/base/css/base.css and just use classes, there is no need to allow it to only be applied to td elements

Fix up the phpdocs for new SVN classes

Split the svn parser off into a new class.  If it is 3rd party code put it into phpgwapi/inc/svnparser and just include it in the top of the svn_dav class

Feel free to commit it

Dave Hall <skwashd>
Group administrator
Wed 13 Sep 2006 10:08:40 AM UTC, original submission:  

Hi all,

The patch here allow people to use svn as a repository, when it's used by apache, and autoversionning system. We add the possibility to see diff, to navigate through revision, look at logs ... You will need the svn command on the server if you want to be able to see diffs.

Then, I add to this, a lot's of E_ALL fixes, some nasty bug with group managing, and remove some dangerous code for DAV/SVN users.

Hope this help



Caeies <Caeies>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10751:  patch_for_svn.tgz added by Caeies (18KiB - application/x-gtar - patch for filemanager ...)


Depends on the following items: None found

Items that depend on this one: None found


CC list is empty


There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


Follow 9 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-24 skwashd StatusDone In Progress
    Open/ClosedClosed Open
2006-10-24 skwashd StatusIn Progress Done
    Open/ClosedOpen Closed
2006-09-17 skwashd StatusReady For Test In Progress
    Assigned toceb Caeies
2006-09-13 Caeies Carbon-Copy- Added -email is unavailable-
2006-09-13 Caeies Attached File- Added patch_for_svn.tgz, #10751
    Carbon-Copy- Added skwashd

Back to the top

Powered by Savane 3.13-ee12.
Corresponding source code