phpGroupWare - Patches: patch #2804, zend patch for fudforum
You are not allowed to post comments on this tracker with your current authentication level.
patch #2804: zend patch for fudforum
Submitter: | Kai Hofmann <powerstat> | ||
Submitted: | Tue 16 Mar 2004 09:03:44 AM UTC | ||
Category: | phpgw-FUDforum | Priority: | 7 - High |
Item Group: | None | Status: | None |
Privacy: | Public | Assigned to: | powerstat |
Open/Closed: | Open |
Sun 21 Mar 2004 02:36:33 PM UTC, comment #2: |
Dave Hall <skwashd>![]() |
Sat 20 Mar 2004 06:36:12 PM UTC, comment #1: I have had a good look through this.
Comments as follows:
returns
Initialising variables before use
and:
other than readability. Initialising arrays before using them was requirement in php3, but was dropped in php4. In addition to this, which is better:
or just
$myar['key2']['value3'] = 1;
display_section($appname,$file);
<br> vs <br />
class.ufud.inc.php
$GLOBALS[] and other variables
From a thorough review of the patch I think it will be more like ~5k rather than 26k. I will post a new version tomorrow
Cheers |
Anonymous |
Tue 16 Mar 2004 09:03:44 AM UTC, original submission:
Problems found with zend code analyzer fixed and partly only marked.
|
Kai Hofmann <powerstat>![]() |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2004-03-21 | skwashd | Assigned to | skwashd | ![]() |
powerstat |
2004-03-21 | skwashd | Attached File | - | ![]() |
Added fud2.patch, #2963 |
2004-03-16 | cboettger | Assigned to | cboettger | ![]() |
skwashd |
Originator Email | ![]() |
-email is unavailable- | |||
Carbon-Copy | - | ![]() |
Added powerstat | ||
2004-03-16 | powerstat | Attached File | - | ![]() |
Added 20040316.patch, #2924 |
Here is the new version - half the size of the original patch