lwIP - A Lightweight TCP/IP stack - Patches: patch #10311, Fix altcp.h's...
You are not allowed to post comments on this tracker with your current authentication level.
patch #10311: Fix altcp.h's altcp_get_tcp_addrinfo define for regular TCP
Submitter: | Shawn Silverman <ssilverman> | ||
Submitted: | Mon 30 Jan 2023 04:57:26 AM UTC | ||
Category: | TCP | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Planned Release: | None |
Attached Files
file #54286: 0001-Fix-altcp.h-s-altcp_get_tcp_addrinfo-define-for-regu.patch added by ssilverman (889B - application/octet-stream)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follows 1 latest change.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-01-30 | ssilverman | Attached File | - | Added 0001-Fix-altcp.h-s-altcp_get_tcp_addrinfo-define-for-regu.patch, #54286 |
Powered by Savane 3.13-bb6a.
Corresponding source code
To be consistent, the function defined in tcp.h should probably be changed to `tcp_get_tcp_addrinfo()` (from `tcp_tcp_get_tcp_addrinfo()`), but the attached way seemed the easiest way to fix the problem without requiring code changes to projects that already use lwIP. It does violate the "just add 'al' to the function name" principle, however, so maybe changing the name in tcp.h is actually better?
A third option is to change the altcp version's function name to `altcp_tcp_get_tcp_addrinfo()`, however there's already a static function defined with that name, so that might add some confusion and other compile issues because of that define being included (via altcp.h) in altcp_tcp.c.