bugGNU gettext - Bugs: bug #56543, Don't treat Icon= in .desktop...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #56543: Don't treat Icon= in .desktop files as translatable

Submitted by:  Will Thompson <wjt>
Submitted on:  Mon 24 Jun 2019 09:51:49 PM UTC  
 
Category:  Desktop Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  Bruno Haible <haible>
Open/Closed:  Closed

Tue 14 Apr 2020 12:19:12 PM UTC, comment #4: 

The fix is contained in gettext 0.20.2.

Bruno Haible <haible>
Project AdministratorIn charge of this item.
Sun 18 Aug 2019 11:37:33 AM UTC, comment #3: 

The issue has been fixed:
- xgettext no longer extracts 'Icon' keys from .desktop files.
- The documentation explains that icons are localizable but not handled by PO files.
https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=commitdiff;h=1c9b7215050412f75b3cb6348aaec13206c7ad20

Thanks all for the discussion!

Bruno Haible <haible>
Project AdministratorIn charge of this item.
Wed 26 Jun 2019 08:21:09 AM UTC, comment #2: 

Let's link to the ongoing discussion on xdg that inspired this request:

https://lists.freedesktop.org/archives/xdg/2019-June/014158.html

Egmont Koblinger <egmont>
Tue 25 Jun 2019 04:58:10 PM UTC, comment #1: 

There is some prior discussion in https://savannah.gnu.org/support/?108887 (reported in support by mistake.)

Piotr Drąg <piotrdrag>
Mon 24 Jun 2019 09:51:49 PM UTC, original submission:  

The spec at https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html defines this field to be a "localestring", and it is faithfully extracted to the .pot file by xgettext.

I have never seen a localized icon, but I have seen many many cases where translators have incorrectly translated icon names as if they were English text, and many .desktop.in files with forlorn comments like "# TRANSLATORS: please do not translate this" before the Icon= line.

I've opened a MR to amend the specification at https://gitlab.freedesktop.org/xdg/xdg-specs/merge_requests/2. There is a reasonable argument that the spec is technically correct: icons do sometimes contain text, and sometimes that text should be translated or transliterated. Even if the spec is not amended, I think it would be useful to be able to control this on a per-project/-file/-key basis, and ideally have it disabled by default, so that the (rare) projects that need this can opt-in and the (widespread) projects that don't need take no action.

Will Thompson <wjt>

 

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by haible (Posted a comment)
  • -email is unavailable- added by egmont (Posted a comment)
  • -email is unavailable- added by piotrdrag (Posted a comment)
  • -email is unavailable- added by piotrdrag
  • -email is unavailable- added by wjt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-18 haible StatusNone => Fixed
        Assigned toNone => haible
        Open/ClosedOpen => Closed
    2019-06-25 piotrdrag Carbon-Copy- => Added piotrdrag
    2019-06-25 wjt Attached File- => Added 0001-Don-t-extract-Icon-field-from-.desktop-files.patch, #47134

    Back to the top


    Powered by Savane 3.5