bugGNU Health - Bugs: bug #64665, Product cost_price needs to be...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #64665: Product cost_price needs to be passed as an argument in stock moves

Submitter:  Luis Falcon <meanmicio>
Submitted:  Thu 14 Sep 2023 11:01:54 AM UTC
   
 
Category:  Functionality Severity:  3 - Normal
Item Group:  None Status:  Ready For Test
Privacy:  Public Assigned to:  meanmicio
Open/Closed:  Open Release:  4.2.0
Module:  stock Component:  Hospital Management

Thu 09 Nov 2023 06:08:35 PM UTC, comment #3: 
Luis Falcon <meanmicio>
Group administrator
Thu 09 Nov 2023 06:01:44 PM UTC, comment #2: 

The issue is reproducible also when generating the stock moves associated to he ambulatory care.

Luis Falcon <meanmicio>
Group administrator
Thu 14 Sep 2023 11:18:24 AM UTC, comment #1: 

Fixed in https://hg.savannah.gnu.org/hgweb/health/rev/12f4250c5c7c

Reviewers, please test

Bests
Luis

Luis Falcon <meanmicio>
Group administrator
Thu 14 Sep 2023 11:01:54 AM UTC, original submission:  

Since Tryton LTS 6.0, the product cost_price is required in certain stock moves.

The issue was introduced by Tryton here:

https://hg.tryton.org/modules/stock/rev/694a0303831f
 
It's related to the storage location type. It applies in these
scenarios:

 from_type != 'storage' and to_type == 'storage'
 from_type == 'storage' and to_type != 'storage'
 from_type != 'drop' and to_type == 'drop'
 from_type == 'drop' and to_type != 'drop'

Under these scenarios, we need to add the cost price as an argument. Because the cost_price is required in the product, I propose to always pass it as an argument, regardless whether it will be used or not when creating the stock move.

health-dev thread with Francisco about this: https://lists.gnu.org/archive/html/health-dev/2023-09/msg00026.html

Luis Falcon <meanmicio>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-11-09 meanmicio StatusIn Progress Ready For Test
    2023-11-09 meanmicio StatusFixed In Progress
        Open/ClosedClosed Open
    2023-09-17 meanmicio StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2023-09-14 meanmicio CategoryNone Functionality
        StatusConfirmed Ready For Test
    2023-09-14 meanmicio ReleaseNone 4.2.0

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code