bugGNU Health - Bugs: bug #62629, Missing requires on setup

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #62629: Missing requires on setup

Submitter:  Sergi Almacellas Abellana <pokoli>
Submitted:  Wed 15 Jun 2022 10:44:09 AM UTC
 
Category:  Packaging Severity:  3 - Normal
Item Group:  None Status:  Need Info
Privacy:  Public Assigned to:  None
Open/Closed:  Open Release:  4.0.0
Module:  healt_caldav Component:  None

Thu 16 Jun 2022 04:50:56 PM UTC, comment #3: 

Thanks, Sergi / Gerald!

When using the standard / vanilla installation, all the python dependencies are met, so there are no errors. In addition, if you need to update the deps, you can run gnuhealth-control instpydeps.

For individual packages, we can work on their corresponding requires at setup scripts as you've done in the patch.

This is the current dependency list that are delivered at installation time.

   # Python packages
    local PIP_LXML="lxml"
    local PIP_RELATORIO="relatorio"
    local PIP_WRAPT="wrapt"
    local PIP_WERKZEUG="werkzeug<2"
    local PIP_DATEUTIL="python-dateutil"
    local PIP_PSYCOPG2="psycopg2-binary"
    local PIP_PYTZ="pytz"
    local PIP_LDAP="python-ldap"
    local PIP_VOBJECT="vobject"
    local PIP_QRCODE="qrcode"
    local PIP_PYBARCODE="python-barcode"
    local PIP_SIX="six"
    local PIP_PILLOW="Pillow"
    local PIP_CALDAV="caldav"
    local PIP_POLIB="polib"
    local PIP_SQL="python-sql"
    local PIP_STDNUM="python-stdnum"
    local PIP_SIMPLEEVAL="simpleeval"
    local PIP_CONFIGPARSER="configparser"
    local PIP_WEBDAV3="pywebdav3-gnuhealth"
    local PIP_BCRYPT="bcrypt"
    local PIP_NUMPY="numpy"
    local PIP_UNOCONV="unoconv"
    local PIP_MAGIC="python-magic"
    local PIP_BEREN="beren==0.7.0"
    local PIP_PENDULUM="pendulum"
    local PIP_MATPLOTLIB="matplotlib"
    local PIP_PASSLIB="passlib"
    local PIP_PYCOUNTRY="pycountry==20.7.3"
    local PIP_PROGRESSBAR="progressbar==2.2"
    local PIP_DEFUSEDXML="defusedxml"

Luis Falcon <meanmicio>
Project Administrator
Wed 15 Jun 2022 11:50:39 AM UTC, comment #2: 

Hi Gearld,

Yes such dependencies may be also required depending on the setup but they are all optional dependencies and the system can work without it.

I just added the dependencies that are required to run the server as I found that in such case if you install the module but not dependency the system crashes.

Sergi Almacellas Abellana <pokoli>
Project Member
Wed 15 Jun 2022 11:43:25 AM UTC, comment #1: 

Great! In addition:
I believe there are more dependency issues.
Working on a pip based installation of GNU Health I had to additionally install the following packages:

psycopg2 (PostgreSQL)
psycopg2cffi (PostgreSQL)
matplotlib
qrcode
barcode
vobject
forex_python (import currencies)
pycountry==20.7.3 (import countries)
proteus (import currencies or countries)
bcrypt (use local demo database)

As I was only installing all the modules those should all be missing dependencies in at least one module.

Besides I tested for all libraries installed during gnuhealth-setup if they are present after pip installation and I was missing:

psycopg2-binary, python-ldap, python-barcode, caldav, configparser, unoconv, progressbar

Those could also be missing requirements. Not sure if psycopg2+psycopg2cffi & psycopg2-binary are alternatives to each other.

original submission:

> I just found that there are some modules that use python packages that are not included on requires, so they are not correctly installed when installing them with python packagins tools.
>
> It will be great to include such requirements. I attach a patch that fixes it.

Gerald Wiese <gerald_wiese>
Project Member
Wed 15 Jun 2022 10:44:09 AM UTC, original submission:  

I just found that there are some modules that use python packages that are not included on requires, so they are not correctly installed when installing them with python packagins tools.

It will be great to include such requirements. I attach a patch that fixes it.

Sergi Almacellas Abellana <pokoli>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #53301:  missing_requires.patch added by pokoli (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by gerald_wiese (Posted a comment)
  • -email is unavailable- added by pokoli (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-06-16 meanmicio StatusNone Need Info
        ReleaseNone 4.0.0
    2022-06-15 pokoli Attached File- Added missing_requires.patch, #53301

    Back to the top


    Powered by Savane 3.9