bugGNU Health - Bugs: bug #62620, crypto plugin & client 4.0 not...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #62620: crypto plugin & client 4.0 not running

Submitter:  Gerald Wiese <gerald_wiese>
Submitted:  Mon 13 Jun 2022 12:44:14 PM UTC
 
Category:  Plugins Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  meanmicio
Open/Closed:  Closed Release:  4.0.0
Module:  gnuhealth client Component:  None

Thu 16 Jun 2022 06:57:26 PM UTC, comment #2: 

Thank you, Gerald!

Fixed on: http://hg.savannah.gnu.org/hgweb/health-hmis-client-plugins/rev/c9e62fbc6113

Just updated the plugins to be 4.0 compatible.

I have also updated the documentation on Wikibooks

PS: Can't reproduce the issue of seeing twice the messages...

Please test and report :)

Bests
Luis

Luis Falcon <meanmicio>
Project Administrator
Mon 13 Jun 2022 01:43:49 PM UTC, comment #1: 

PS:
Seems like removing GH_PLUGINS_DIR had a sense because without it the options for signing & verifying don't appear twice. Didn't get that before...

original submission:

> Hey,
> I spent some time getting the crypto plugin running inside the 4.0 client.
> The main problem was that the folder 'tryton' in client 3.8 was renamed to 'gnuhealth' in client 4.0. Since crypto plugin did not change since 3.6 it was still trying to import from 'tryton' instead of 'gnuhealth' and the errors didn't appear in the logs.
>
> There are a few questions & problems:
> - Shouldn't the folder in the PyPI package 'gnuhealth-client' be 'gnuhealth_client' or something instead of 'gnuhealth' since there is a PyPI package 'gnuhealth'?
> - For Crypto plugin at least those imports should be fixed and released as 4.0.x. Maybe an alternative way of downloading an archive could be provided as well? PyPI?
> - In client in gnuhealth/plugins/__init__.py 'GH_PLUGINS_DIR' is not used anymore even though it is still defined in gnuhealth/config.py
> - For loading modules in gnuhealth/plugins/__init__.py exceptions should at least be printed, this was really painful to find the problem if nothing is printed after an error even in debug mode. So after 'except ImportError:' there should at least be some debug output instead of just 'continue'.
> - When the crypto plugin is working and I click on the gear for actions, the options for signing and verifying documents appear twice. I guess once is enough? ;)
>
> Best
> Gerald

Gerald Wiese <gerald_wiese>
Project Member
Mon 13 Jun 2022 12:44:14 PM UTC, original submission:  

Hey,
I spent some time getting the crypto plugin running inside the 4.0 client.
The main problem was that the folder 'tryton' in client 3.8 was renamed to 'gnuhealth' in client 4.0. Since crypto plugin did not change since 3.6 it was still trying to import from 'tryton' instead of 'gnuhealth' and the errors didn't appear in the logs.

There are a few questions & problems:
- Shouldn't the folder in the PyPI package 'gnuhealth-client' be 'gnuhealth_client' or something instead of 'gnuhealth' since there is a PyPI package 'gnuhealth'?
- For Crypto plugin at least those imports should be fixed and released as 4.0.x. Maybe an alternative way of downloading an archive could be provided as well? PyPI?
- In client in gnuhealth/plugins/__init__.py 'GH_PLUGINS_DIR' is not used anymore even though it is still defined in gnuhealth/config.py
- For loading modules in gnuhealth/plugins/__init__.py exceptions should at least be printed, this was really painful to find the problem if nothing is printed after an error even in debug mode. So after 'except ImportError:' there should at least be some debug output instead of just 'continue'.
- When the crypto plugin is working and I click on the gear for actions, the options for signing and verifying documents appear twice. I guess once is enough? ;)

Best
Gerald

Gerald Wiese <gerald_wiese>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by meanmicio (Posted a comment)
  • -email is unavailable- added by gerald_wiese (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-07-02 meanmicio Open/ClosedOpen Closed
    2022-07-02 meanmicio StatusReady For Test Fixed
    2022-06-16 meanmicio CategoryNone Plugins
        StatusNone Ready For Test
        Assigned toNone meanmicio
        ReleaseNone 4.0.0

    Back to the top


    Powered by Savane 3.9