GNU Health - Bugs: bug #62021, DU: 5e not possible
You are not allowed to post comments on this tracker with your current authentication level.
bug #62021: DU: 5e not possible
Submitter: | Gerald Wiese <gerald_wiese> | ||
Submitted: | Thu 10 Feb 2022 01:23:03 PM UTC | ||
Category: | GUI / Frontend | Severity: | 3 - Normal |
Item Group: | None | Status: | Fixed |
Privacy: | Public | Assigned to: | meanmicio |
Open/Closed: | Closed | Release: | 3.9.0 |
Module: | health | Component: | None |
Wed 16 Feb 2022 05:53:14 PM UTC, comment #1: |
Luis Falcon <meanmicio> |
Thu 10 Feb 2022 01:23:03 PM UTC, original submission:
For addresses in domiciliary units entering "my street 5e" is not possible because number only accepts numbers. One could enter the "e" as appartment but then it won't appear in the open street map link and in the displayed address below.
|
Gerald Wiese <gerald_wiese> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2022-03-05 | meanmicio | Status | Ready For Test | Fixed | |
Open/Closed | Open | Closed | |||
2022-02-16 | meanmicio | Status | None | Ready For Test | |
Assigned to | None | meanmicio | |||
Release | None | 3.9.0 |
Powered by Savane 3.13-caa5.
Corresponding source code
Hi, Gerald!
Fixed on https://hg.savannah.gnu.org/hgweb/health/rev/ffc27c3ecc25
Thanks for the input. Indeed, the current OSM allows non-integers in the street number, so I have changed it.
Because the change from INT to VARCHAR at PG level required a casting for the current values, I have included the statement in the the "before.sql" and re-exec before doing trytond-admin --update.
If you have already done so, you can just execute the last line directly on the psql client. Just make sure that the field "address_street_number" shows type "character varying".
I have also include the valid OSM key Unit (addr:unit) to include extra generic info (ie, apt. unit / number / floor.., ej "F", "4L"..)
Changes done:
[x] update from int to varchar street number to meet openstreetmap requirements
[x] Include the Unit parameter to be use in the form and in the OSM queries as a valid address subunit
[x] Use f-string in the address representation
[x] Fix parent subdivision format.
Please check.
Bests
Luis